Cosmetic cleanup and binary mode read for powershell script

Author: HD Moore

modules/payloads/singles/cmd/windows/powershell_bind_tcp.rb

@@ -48,13 +48,11 @@ def generate
     lport = datastore['LPORT']
     lhost = datastore['LHOST']
 
-    template_path = File.join(
-    Msf::Config.data_directory,
-    'exploits',
-    'powershell',
-    'powerfun.ps1')
-
-    script_in = File.read(template_path)
+    template_path = ::File.join( Msf::Config.data_directory, 'exploits', 'powershell','powerfun.ps1')
+    script_in = ""
+    ::File.open(template_path, "rb") do |fd|
+      script_in << fd.read(fd.stat.size)
+    end
     script_in << "\npowerfun -Command bind"
 
     mods = ''

modules/payloads/singles/cmd/windows/powershell_reverse_tcp.rb

@@ -48,13 +48,12 @@ def generate
     lport = datastore['LPORT']
     lhost = datastore['LHOST']
 
-    template_path = File.join(
-    Msf::Config.data_directory,
-    'exploits',
-    'powershell',
-    'powerfun.ps1')
+    template_path = ::File.join( Msf::Config.data_directory, 'exploits', 'powershell','powerfun.ps1')
+    script_in = ""
+    ::File.open(template_path, "rb") do |fd|
+      script_in << fd.read(fd.stat.size)
+    end
 
-    script_in = File.read(template_path)
     script_in << "\npowerfun -Command reverse"
 
     mods = ''

modules/payloads/singles/windows/powershell_bind_tcp.rb

@@ -53,11 +53,11 @@ def initialize(info = {})
   def command_string
     lport = datastore['LPORT']
 
-    template_path = File.join(
-    Msf::Config.data_directory,
-    'exploits',
-    'powershell',
-    'powerfun.ps1')
+    template_path = ::File.join( Msf::Config.data_directory, 'exploits', 'powershell','powerfun.ps1')
+    script_in = ""
+    ::File.open(template_path, "rb") do |fd|
+      script_in << fd.read(fd.stat.size)
+    end
 
     script_in = File.read(template_path)
     script_in << "\npowerfun -Command bind"

modules/payloads/singles/windows/powershell_reverse_tcp.rb

@@ -54,13 +54,11 @@ def command_string
     lport = datastore['LPORT']
     lhost = datastore['LHOST']
 
-    template_path = File.join(
-    Msf::Config.data_directory,
-    'exploits',
-    'powershell',
-    'powerfun.ps1')
-
-    script_in = File.read(template_path)
+    template_path = ::File.join( Msf::Config.data_directory, 'exploits', 'powershell','powerfun.ps1')
+    script_in = ""
+    ::File.open(template_path, "rb") do |fd|
+      script_in << fd.read(fd.stat.size)
+    end
     script_in << "\npowerfun -Command reverse"
 
     mods = ''