Skip to content

Commit fc4da53

Browse files
committed
More fixes
1 parent e28e1b8 commit fc4da53

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

modules/post/windows/gather/local_admin_search_enum.rb

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def setup
6262
@adv = client.railgun.advapi32
6363

6464
# Get domain and domain controller if options left blank
65-
if datastore['DOMAIN'].nil?
65+
if datastore['DOMAIN'].nil? or datastore['DOMAIN'].empty?
6666
user = client.sys.config.getuid
6767
datastore['DOMAIN'] = user.split('\\')[0]
6868
end
@@ -104,7 +104,6 @@ def enum_users(host)
104104
winsessions = client.railgun.netapi32.NetWkstaUserEnum("\\\\#{host}", 1, 4, -1, 4, 4, nil)
105105
rescue ::Exception => e
106106
print_error("Issue enumerating users on #{host}")
107-
vprint_error(e.backtrace)
108107
return userlist
109108
end
110109

@@ -119,7 +118,7 @@ def enum_users(host)
119118
mem = client.railgun.memread(startmem, 8*count)
120119
rescue ::Exception => e
121120
print_error("Issue reading memory for #{host}")
122-
vprint_error(e.backtrace)
121+
vprint_error(e.to_s)
123122
return userlist
124123
end
125124
# For each entry returned, get domain and name of logged in user
@@ -162,26 +161,25 @@ def enum_users(host)
162161
def enum_groups(user)
163162
grouplist = ""
164163

165-
dc = "\\\\#{datastore['DOMAIN_CONTROLLER']}"
164+
dc = "\\\\#{@domain_controller}"
166165
begin
167166
# Connect to DC and enumerate groups of user
168167
usergroups = client.railgun.netapi32.NetUserGetGroups(dc, user, 0, 4, -1, 4, 4)
169-
170168
rescue ::Exception => e
171169
print_error("Issue connecting to DC, try manually setting domain and DC")
172-
vprint_error(e.backtrace)
170+
vprint_error(e.to_s)
173171
return grouplist
174172
end
175173

176-
count = usergroups['totalentries']
177-
startmem = usergroups['bufptr']
178-
base = 0
174+
count = usergroups['totalentries']
175+
startmem = usergroups['bufptr']
176+
base = 0
179177

180178
begin
181179
mem = client.railgun.memread(startmem, 8*count)
182180
rescue ::Exception => e
183181
print_error("Issue reading memory for groups for user #{user}")
184-
vprint_error(e.backtrace)
182+
vprint_error(e.to_s)
185183
return grouplist
186184
end
187185

0 commit comments

Comments
 (0)