Skip to content

Commit fc803ae

Browse files
committed
Changed msftidy check
send_request_raw does not support vars_get so change the message to switch to send_request_cgi. See rapid7#3272 for more info
1 parent fda6ed3 commit fc803ae

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

tools/msftidy.rb

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,10 +485,18 @@ def check_vuln_codes
485485
end
486486

487487
def check_vars_get
488-
test = @source.scan(/send_request_(?:cgi|raw)\s*\(\s*\{?\s*['"]uri['"]\s*=>\s*[^=})]*?\?[^,})]+/im)
488+
test = @source.scan(/(send_request_(cgi|raw)\s*\(\s*\{?\s*['"]uri['"]\s*=>\s*[^=})]*?\?[^,})]+)/im)
489489
unless test.empty?
490490
test.each { |item|
491-
warn("Please use vars_get in send_request_cgi and send_request_raw: #{item}")
491+
case item[1]
492+
when 'cgi'
493+
warn("Please use vars_get in send_request_cgi: #{item[0]}")
494+
when 'raw'
495+
# send_request_raw does not support vars_getiirb
496+
warn("Please use vars_get and switch to send_request_cgi: #{item[0]}")
497+
else
498+
raise('Error in regex')
499+
end
492500
}
493501
end
494502
end

0 commit comments

Comments
 (0)