Skip to content

Commit 7d6a987

Browse files
committed
[base-components] some ellipsis improvements
1 parent 0bbc02f commit 7d6a987

File tree

74 files changed

+3065
-2172
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+3065
-2172
lines changed

pnpm-lock.yaml

Lines changed: 5 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semcore/base-components/__tests__/ellipsis.browser-test.tsx

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { expect, test } from '@semcore/testing-utils/playwright';
44
test.describe('Visual - link', () => {
55
const withEllipsis = [
66
{ ellipsis: true },
7-
{ ellipsis: { trim: 'middle' } },
8-
{ ellipsis: { trim: 'end' } },
9-
{ ellipsis: { trim: 'end', maxLine: 2 } },
7+
{ ellipsis: { cropPosition: 'middle' } },
8+
{ ellipsis: { cropPosition: 'end' } },
9+
{ ellipsis: { cropPosition: 'end', maxLine: 2 } },
1010
{ ellipsis: { maxLine: 2 } },
1111
];
1212

@@ -39,7 +39,7 @@ test.describe('Visual - link', () => {
3939

4040
const withoutEllipsis = [
4141
{ ellipsis: false },
42-
{ ellipsis: { trim: 'end', maxLine: 6 } },
42+
{ ellipsis: { cropPosition: 'end', maxLine: 6 } },
4343
];
4444

4545
withoutEllipsis.forEach((item) => {
@@ -63,21 +63,21 @@ test.describe('Visual - link', () => {
6363
test.describe('Visual - text', () => {
6464
const withEllipsis = [
6565
{ ellipsis: true, size: 100 },
66-
{ ellipsis: { trim: 'end' }, size: 200 },
66+
{ ellipsis: { cropPosition: 'end' }, size: 200 },
6767
{ ellipsis: true, size: 200 },
68-
{ ellipsis: { trim: 'end' }, size: 400 },
68+
{ ellipsis: { cropPosition: 'end' }, size: 400 },
6969
{ ellipsis: true, size: 500 },
70-
{ ellipsis: { trim: 'end' }, size: 600 },
70+
{ ellipsis: { cropPosition: 'end' }, size: 600 },
7171
{ ellipsis: true, size: 700 },
72-
{ ellipsis: { trim: 'end' }, size: 800 },
73-
{ ellipsis: { trim: 'middle' }, size: 100 },
74-
{ ellipsis: { trim: 'middle' }, size: 200 },
75-
{ ellipsis: { trim: 'middle' }, size: 300 },
76-
{ ellipsis: { trim: 'middle' }, size: 400 },
77-
{ ellipsis: { trim: 'middle' }, size: 500 },
78-
{ ellipsis: { trim: 'middle' }, size: 600 },
79-
{ ellipsis: { trim: 'middle' }, size: 700 },
80-
{ ellipsis: { trim: 'middle' }, size: 800 },
72+
{ ellipsis: { cropPosition: 'end' }, size: 800 },
73+
{ ellipsis: { cropPosition: 'middle' }, size: 100 },
74+
{ ellipsis: { cropPosition: 'middle' }, size: 200 },
75+
{ ellipsis: { cropPosition: 'middle' }, size: 300 },
76+
{ ellipsis: { cropPosition: 'middle' }, size: 400 },
77+
{ ellipsis: { cropPosition: 'middle' }, size: 500 },
78+
{ ellipsis: { cropPosition: 'middle' }, size: 600 },
79+
{ ellipsis: { cropPosition: 'middle' }, size: 700 },
80+
{ ellipsis: { cropPosition: 'middle' }, size: 800 },
8181

8282
];
8383

@@ -96,7 +96,7 @@ test.describe('Visual - text', () => {
9696

9797
const withoutEllipsis = [
9898
{ ellipsis: false },
99-
{ ellipsis: { trim: 'end', maxLine: 6 } },
99+
{ ellipsis: { cropPosition: 'end', maxLine: 6 } },
100100
];
101101

102102
withoutEllipsis.forEach((item) => {

0 commit comments

Comments
 (0)