Inconsistent field names in decoding: min vs. minute, sec vs. second

[Manu3l0us]

The field names for minutes and seconds in the decoded messages are not consistent.

Example:
NAV-PVT: min, second
NAV-PVAT: min, sec
LOG-RETRIEVEPOS: minute, second

Using minute and second consistently would make usage, especially together with pandas, easier.

[semuadmin]

Hi @Manu3l0us,

It's a fair point, and there are probably other examples. In pyubx2 I've endeavoured to use the names as they're documented in whichever Interface Specifications I originally referenced, but these are not always consistent (both between individual UBX message types, between different receiver models and between successive UBX protocol generations).

The problem with making such a change now is the regression impact on users who may be ...

1. already referencing the existing attribute names in code.
2. expecting the definition to match a specific Interface Specification.

I'm going to convert this to a discussion for the time being, but will consider the impact further...

[Manu3l0us]

@semuadmin Thx, I agree with your points. Changing it now would certainly break existing code.

One could think about duplicating the keys for second and minute as min and sec as there is no way to alias keys in a standard dictionary according to my quick research. In that specific case, the impact on memory and performance should be rather negligible, but it is not a very elegant solution.