Skip to content

Commit 8d790aa

Browse files
committed
fix: handle null values when converting arrays to set and list
1 parent d869fb1 commit 8d790aa

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

android/src/main/java/com/sendbird/calls/reactnative/utils/CallsUtils.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,15 +277,15 @@ object CallsUtils {
277277
fun convertArrayToSet(array: ReadableArray): Set<String> {
278278
val set = mutableSetOf<String>()
279279
for (i in 0 until array.size()) {
280-
set.add(array.getString(i))
280+
array.getString(i)?.let { set.add(it) }
281281
}
282282
return set
283283
}
284284

285285
fun convertArrayToList(array: ReadableArray): List<String> {
286286
val list = mutableListOf<String>()
287287
for (i in 0 until array.size()) {
288-
list.add(array.getString(i))
288+
array.getString(i)?.let { list.add(it) }
289289
}
290290
return list
291291
}

android/src/oldarch/java/com/sendbird/calls/reactnative/RNSendbirdCallsModule.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ class RNSendbirdCallsModule(private val reactContext: ReactApplicationContext) :
5757
override fun getOngoingCalls(promise: Promise) = module.getOngoingCalls(promise)
5858
@ReactMethod
5959
override fun getDirectCall(callId: String, promise: Promise) = module.getDirectCall(callId, promise)
60-
@ReactMethod
61-
override fun initialize(appId: String) = module.initialize(appId)
60+
@ReactMethod(isBlockingSynchronousMethod = true)
61+
override fun initialize(appId: String): Boolean = module.initialize(appId)
6262
@ReactMethod
6363
override fun authenticate(authParams: ReadableMap, promise: Promise) = module.authenticate(authParams, promise)
6464
@ReactMethod

0 commit comments

Comments
 (0)