Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Sep 29, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7606](https://sendbird.atlassian.net/browse/CLNP-7606)

Description Of Changes

SendbirdCallsModule, DirectCall, Room 에 updateCustomItems, deleteCustomItems, deleteAllCustomItems 를 추가하였습니다.
room 의 deleteAllCustomItems 의 경우 Android calls 에서 해당 API를 지원하지 않아 deleteCustomItems 를 사용하도록 예외 처리 하였습니다.

추가로 Android 16kb 지원을 위해 calls 버전을 변경하였습니다.

iOS, Andorid 디바이스에서 테스트 완료 하였습니다.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee requested a review from Copilot September 29, 2025 06:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements custom item management functionality for both DirectCall and GroupCall (Room) objects, adding support for updating, deleting, and deleting all custom items. Custom items are key-value pairs that can be stored with calls and rooms.

  • Adds three new methods (updateCustomItems, deleteCustomItems, deleteAllCustomItems) to both DirectCall and Room interfaces
  • Implements the native bridge methods for iOS and Android platforms
  • Updates TypeScript type definitions to properly omit the native module methods from the JS interface types

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/types/Room.ts Updates Room type definitions to add custom item methods and exclude native methods from JS interface
src/types/NativeModule.ts Adds native module method signatures for custom items operations
src/types/Call.ts Updates DirectCall type definitions with custom item methods and proper type exclusions
src/libs/SendbirdCallsModule.tsx Implements common custom items operations with local state updates
src/libs/Room.ts Implements Room-specific custom items methods with native bridge calls
src/libs/DirectCall.ts Implements DirectCall-specific custom items methods and static update helper
ios/RNSendbirdCalls.swift Adds iOS native bridge method implementations
ios/RNSendbirdCalls.m Adds iOS native method exports for React Native bridge
ios/Modules/CallsModule.swift Implements iOS module delegation for custom items operations
ios/Modules/CallsModule+GroupCall.swift Implements iOS GroupCall custom items functionality
ios/Modules/CallsModule+DirectCall.swift Implements iOS DirectCall custom items functionality
ios/Modules/CallsModule+Common.swift Implements iOS common custom items operations
android/src/oldarch/java/com/sendbird/calls/reactnative/RNSendbirdCallsModule.kt Adds Android old architecture native method bindings
android/src/main/java/com/sendbird/calls/reactnative/utils/CallsUtils.kt Adds utility functions for data conversion between JS and native types
android/src/main/java/com/sendbird/calls/reactnative/module/CallsModuleStruct.kt Updates Android module interface definitions
android/src/main/java/com/sendbird/calls/reactnative/module/CallsModule.kt Implements Android module delegation
android/src/main/java/com/sendbird/calls/reactnative/module/CallsGroupCallModule.kt Implements Android GroupCall custom items functionality
android/src/main/java/com/sendbird/calls/reactnative/module/CallsDirectCallModule.kt Implements Android DirectCall custom items functionality
android/src/main/java/com/sendbird/calls/reactnative/module/CallsCommonModule.kt Implements Android common custom items operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@OnestarLee OnestarLee requested a review from Copilot September 29, 2025 07:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@OnestarLee OnestarLee changed the title feat/implement-custom-item [CLNP-7606] feat/implement-custom-item Sep 29, 2025
@OnestarLee OnestarLee changed the title [CLNP-7606] feat/implement-custom-item [CLNP-7606] feat/implement-custom-item and android 16kb support Sep 29, 2025
@OnestarLee OnestarLee requested a review from bang9 September 29, 2025 07:36
@OnestarLee OnestarLee self-assigned this Sep 29, 2025
@OnestarLee
Copy link
Collaborator Author

추가로 registerPushToken, unregisterPushToken deprecated 될 api사용하고있어서 변경했습니다

@OnestarLee OnestarLee requested a review from bang9 September 30, 2025 05:39
Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OnestarLee OnestarLee merged commit c8ff900 into main Sep 30, 2025
8 checks passed
@OnestarLee OnestarLee deleted the feat/implement-custom-item branch September 30, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants