Skip to content

Commit 2523ddd

Browse files
committed
chore: apply review
1 parent df48e2c commit 2523ddd

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

packages/uikit-react-native/src/domain/groupChannel/module/moduleContext.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@ export const GroupChannelContexts: GroupChannelContextsType = {
2828
channel: {} as SendbirdGroupChannel,
2929
setMessageToEdit: NOOP,
3030
setMessageToReply: NOOP,
31-
scrollToMessage: (_: number) => {
32-
// noop
33-
},
34-
__internalSetScrollToMessageFunc: (_: () => GroupChannelScrollToMessageFunc) => {
31+
scrollToMessage: (() => false) as GroupChannelScrollToMessageFunc,
32+
__internalSetScrollToMessageFunc: (_func: () => GroupChannelScrollToMessageFunc) => {
3533
// noop
3634
},
3735
}),
@@ -64,6 +62,7 @@ export const GroupChannelContextsProvider: GroupChannelModule['Provider'] = ({
6462
Logger.error(
6563
'You should render `src/domain/groupChannel/component/GroupChannelMessageList.tsx` component first to use scrollToMessage.',
6664
);
65+
return false;
6766
});
6867

6968
const updateInputMode = (mode: 'send' | 'edit' | 'reply', message?: SendbirdUserMessage | SendbirdFileMessage) => {

packages/uikit-react-native/src/domain/groupChannel/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import type { PubSub } from '../../utils/pubsub';
3636
export type GroupChannelScrollToMessageFunc = (
3737
messageId: number,
3838
options?: { focusAnimated?: boolean; viewPosition?: number },
39-
) => void;
39+
) => boolean;
4040

4141
export interface GroupChannelProps {
4242
Fragment: {

0 commit comments

Comments
 (0)