[CLNP-5612] fix: revert android camera permission #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
========================================
Coverage 11.57% 11.57%
========================================
Files 356 356
Lines 8390 8390
Branches 2341 2202 -139
========================================
Hits 971 971
- Misses 7343 7418 +75
+ Partials 76 1 -75 ☔ View full report in Codecov by Sentry. |
bang9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
CLNP-5612
Description Of Changes
In the image picker library, camera permission is not a mandatory requirement. However, if camera permission is declared in the AndroidManifest.xml, it becomes mandatory to have this permission to call the launchCamera method.
In UIKit, it’s not possible to know if permissions are declared in the customer's app's AndroidManifest.xml, so it enforces the addition and requests the necessary permissions.
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_