Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Feb 5, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

SDKRLSD-1530

Description Of Changes

Fixed duplicate MB text appearing when uploading files over 25MB

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee changed the title chore: update changelog draft [SDKRLSD-] chore: release 3.8.4 Feb 5, 2025
@OnestarLee
Copy link
Collaborator Author

/bot create ticket

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

@sendbird-sdk-deployment
Copy link
Collaborator

[Creating Ticket] 🔖 Done https://sendbird.atlassian.net/browse/SDKRLSD-1530

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.53%. Comparing base (aac95f3) to head (f995ece).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #227    +/-   ##
========================================
  Coverage   11.53%   11.53%            
========================================
  Files         357      357            
  Lines        8460     8460            
  Branches     2368     2248   -120     
========================================
  Hits          976      976            
- Misses       7409     7483    +74     
+ Partials       75        1    -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OnestarLee OnestarLee requested a review from bang9 February 5, 2025 01:44
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by automation

@OnestarLee OnestarLee added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 01bcefd Feb 5, 2025
2 checks passed
@OnestarLee OnestarLee deleted the release/3.8.4 branch February 5, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants