-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-6587] feat: support for RN 0.77+ #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- packages/uikit-react-native/package.json: Language not supported
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 11.53% 11.51% -0.03%
==========================================
Files 357 358 +1
Lines 8460 8479 +19
Branches 2248 2371 +123
==========================================
Hits 976 976
- Misses 7483 7502 +19
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- docs-validation/package.json: Language not supported
- packages/uikit-react-native/package.json: Language not supported
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
|
@bang9 수정하였습니다~ |
packages/uikit-react-native/src/platform/openDocument.native.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 고생하셨습니다.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-6587](https://sendbird.atlassian.net/browse/CLNP-6534)
Description Of Changes
I tested the issue on both RN 0.75 and RN 0.78
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_