Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Apr 10, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-6587](https://sendbird.atlassian.net/browse/CLNP-6534)

Description Of Changes

  • Fixed FlatList-related issue caused by Metro 0.81.3+
  • react-native-document-picker is not compatible with RN 0.77+, so added optional support for @react-native-documents/picker

I tested the issue on both RN 0.75 and RN 0.78

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee requested a review from Copilot April 10, 2025 07:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • packages/uikit-react-native/package.json: Language not supported

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 11.51%. Comparing base (6c19b24) to head (1514812).

Files with missing lines Patch % Lines
...t-react-native/src/platform/openDocument.native.ts 0.00% 24 Missing ⚠️
...ct-native/src/platform/createFileService.native.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   11.53%   11.51%   -0.03%     
==========================================
  Files         357      358       +1     
  Lines        8460     8479      +19     
  Branches     2248     2371     +123     
==========================================
  Hits          976      976              
- Misses       7483     7502      +19     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title feat: add optional support for @react-native-documents/picker [CLNP-6587] feat: support for RN 0.77+ Apr 10, 2025
@OnestarLee OnestarLee requested a review from Copilot April 10, 2025 08:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • docs-validation/package.json: Language not supported
  • packages/uikit-react-native/package.json: Language not supported

@OnestarLee OnestarLee requested a review from bang9 April 10, 2025 08:15
@OnestarLee OnestarLee requested a review from bang9 April 10, 2025 09:59
@OnestarLee
Copy link
Collaborator Author

@bang9 수정하였습니다~

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 고생하셨습니다.

@OnestarLee OnestarLee added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 7176a88 Apr 11, 2025
7 checks passed
@OnestarLee OnestarLee deleted the feat/migrate-document-picker branch April 11, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants