Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Apr 14, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-6592](https://sendbird.atlassian.net/browse/CLNP-6592)

Description Of Changes

Bump minimum expo-media-library version for Android policy compliance

Refactor permission handling for save

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 11.50%. Comparing base (4181505) to head (71fedf0).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...eact-native/src/platform/createFileService.expo.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   11.51%   11.50%   -0.01%     
==========================================
  Files         358      358              
  Lines        8479     8485       +6     
  Branches     2373     2373              
==========================================
  Hits          976      976              
- Misses       7428     7434       +6     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title refactor: bump minimum expo-media-library version for android policy compliance [CLNP-6592] refactor: bump minimum expo-media-library version for android policy compliance Apr 14, 2025
@OnestarLee OnestarLee requested review from bang9 and Copilot and removed request for Copilot April 14, 2025 07:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/uikit-react-native/package.json: Language not supported

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

TODO: Replace blockedPermissions to expo/expo#36142

@OnestarLee OnestarLee added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit a5d6ff8 Apr 14, 2025
7 checks passed
@OnestarLee OnestarLee deleted the feat/bump-minimum-expo-media-library-version branch April 14, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants