-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-6807] feat: add support for custom FlatList component in message list #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 11.49% 11.49% -0.01%
==========================================
Files 358 358
Lines 8489 8490 +1
Branches 2394 2395 +1
==========================================
Hits 976 976
- Misses 7438 7439 +1
Partials 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a custom FlatList component in the message list by introducing a new optional prop ("flatListComponent") and propagating it through the GroupChannelFragment, ChannelMessageList, and ChatFlatList components.
- Introduces "flatListComponent" prop in the GroupChannelFragment and corresponding TypeScript types.
- Updates ChatFlatList to use the provided custom FlatList component or fallback to the default internal component.
- Propagates the prop through ChannelMessageList to enable custom FlatList rendering.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx | Adds the "flatListComponent" prop and passes it to the message list. |
| packages/uikit-react-native/src/domain/groupChannel/types.ts | Updates types to include the optional "flatListComponent". |
| packages/uikit-react-native/src/components/ChatFlatList/index.tsx | Adjusts ChatFlatList to conditionally render the custom FlatList. |
| packages/uikit-react-native/src/components/ChannelMessageList/index.tsx | Passes the "flatListComponent" prop down to ChatFlatList. |
bang9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
… FlatList in message list
…to feat/supprot-custom-flatlist
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-6807](https://sendbird.atlassian.net/browse/CLNP-6807)
Description Of Changes
Added flatListComponent to GroupChannelFragment to support customization
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_