Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Jul 2, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-6755

Description Of Changes

Fixed an issue where BottomSheet components were not appearing when using DrawerNavigator.
This issue occurs only on Android. I have tested it on both iOS and Android.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 11.49%. Comparing base (15ed2fd) to head (c92a0c2).

Files with missing lines Patch % Lines
...t-native-foundation/src/components/Modal/index.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   11.49%   11.49%           
=======================================
  Files         358      358           
  Lines        8490     8490           
  Branches     2395     2395           
=======================================
  Hits          976      976           
  Misses       7439     7439           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title fix: fix BottomSheet not appearing when using DrawerNavigator [CLNP-6775]fix : BottomSheet not appearing when using DrawerNabigator Jul 2, 2025
@OnestarLee OnestarLee requested review from bang9 and Copilot and removed request for Copilot July 2, 2025 11:23
@OnestarLee
Copy link
Collaborator Author

@bang9 prettier 적용되면서 diff가 지저분해졌는데 RNModal 상단에 View 컴포넌트 하나 추가된 PR 입니다

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where BottomSheet components fail to appear when a DrawerNavigator is present by ensuring the modal’s host view is attached correctly.

  • Imported View and wrapped the RNModal in a <View> container.
  • Reformatted the backdrop style array to a multi-line structure for readability.

@OnestarLee OnestarLee changed the title [CLNP-6775]fix : BottomSheet not appearing when using DrawerNabigator [CLNP-6755]fix : BottomSheet not appearing when using DrawerNabigator Jul 2, 2025
Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OnestarLee OnestarLee added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 2fd5b8c Jul 7, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/CLNP-6755-modal-not-showing-with-drawer-navigator branch July 7, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants