-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-7469] fix: improve keyboard avoidance behavior for Android API 35+ #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 11.27% 11.26% -0.01%
==========================================
Files 360 360
Lines 8676 8680 +4
Branches 2328 2450 +122
==========================================
Hits 978 978
- Misses 7697 7701 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes keyboard avoidance behavior for Android API 35+ devices where enhanced edge-to-edge enforcement causes the keyboard to obscure the ChannelInput component. The solution adds platform-specific handling while maintaining backward compatibility with older Android versions.
- Adds Android API 35+ detection logic for keyboard avoidance
- Updates keyboard behavior configuration to use padding on Android API 35+
- Conditionally removes SafeAreaBottom component for Android API 35+
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
bang9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7469](https://sendbird.atlassian.net/browse/CLNP-7469)
Description Of Changes
Android API 35 에서 강화된 edge-to-edge 적용 으로 인해 keyboard 가 ChannelInput을 가리는 문제입니다.
기존 코드는 유지하고 35 이상에서만 예외처리 추가하였습니다.
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_