Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Aug 29, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7507](https://sendbird.atlassian.net/browse/CLNP-7507)

Description Of Changes

Android API 35 에서 버튼 네비게이션 사용시 Input 영역히 겹치는 문제 수정하였습니다.
image
최근에 Android API 35 대응으로 수정된 코드기준으로 키보드가 보이지 않을때는 SafeArea가 적용되어야 합니다.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.24%. Comparing base (b696e3b) to head (837606c).

Files with missing lines Patch % Lines
...react-native/src/components/ChannelInput/index.tsx 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   11.25%   11.24%   -0.02%     
==========================================
  Files         360      360              
  Lines        8686     8698      +12     
  Branches     2335     2338       +3     
==========================================
  Hits          978      978              
- Misses       7707     7719      +12     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title fix: improve keyboard handling when using button navigation on API 35 [CLNP-7507] fix: improve keyboard handling when using button navigation on API 35 Aug 29, 2025
@OnestarLee OnestarLee requested a review from bang9 August 29, 2025 06:50
@OnestarLee OnestarLee added this pull request to the merge queue Aug 31, 2025
Merged via the queue into main with commit 6e78bb4 Aug 31, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/resolve-android-api-35-keyboard-avoid branch August 31, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants