Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Sep 5, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7537](https://sendbird.atlassian.net/browse/CLNP-7537)

Description Of Changes

Android API 35+ 에서 edge-to-dege 대응으로 추가했던 로직이 RN 버전에따라 높이 값이 안맞는 문제가 발견 되었습니다.
ReactNative에서 관련 이슈가 등록된 상태라 언젠가 수정이 될거로 예상되고
추후 호환성을 위해 일단 코드 롤백하고, 릴리즈 노트와 고객에게 MainActivity.kt를 수정하도록 가이드할 예정입니다

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 11.22%. Comparing base (b53e439) to head (9b27ce9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...react-native/src/components/ChannelInput/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   11.20%   11.22%   +0.02%     
==========================================
  Files         360      360              
  Lines        8732     8716      -16     
  Branches     2486     2460      -26     
==========================================
  Hits          978      978              
- Misses       7678     7737      +59     
+ Partials       76        1      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee requested review from bang9 and Copilot September 5, 2025 08:24
@OnestarLee OnestarLee changed the title revert: improve keyboard avoidance behavior for Android API 35+ [CLNP-7537] revert: improve keyboard avoidance behavior for Android API 35+ Sep 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts keyboard avoidance behavior improvements that were specifically added for Android API 35+ due to compatibility issues with different React Native versions. The changes remove edge-to-edge layout handling logic and revert to the previous keyboard avoidance implementation.

  • Removes Android API 35+ specific keyboard avoidance logic including conditional padding behavior
  • Eliminates keyboard visibility tracking state and related event listeners
  • Simplifies keyboard vertical offset calculation back to the original implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge-to-edge 가 문제가 많군요..

@OnestarLee OnestarLee added this pull request to the merge queue Sep 6, 2025
Merged via the queue into main with commit 3dbd622 Sep 6, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/revert-keyboard-avoidance-android-api35 branch September 6, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants