Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Nov 10, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7712](https://sendbird.atlassian.net/browse/CLNP-7712)

Description Of Changes

metro.config.js 에서 unstable_enablePackageExports 옵션과 resolverMainFields 셋팅 처리에 따라서 package.json 에 exports 필드가 존재하지 않을때 폴백 처리로 인해서 동일한 패키지가 cjs, esm으로 중복 로드 되는 경우가 있습니다. 사용자가 어떤 셋팅을하더라도 동일한 모듈이 로드되도록 exports 를 추가하였습니다

ex) 사용자가 unstable_enablePackageExports 를 true resolverMainFields 의 우선순위를 main 으로 하는경우
샘플의 chat-js 에는 exports 필드가 존재하기때문에 esm 모듈을 사용,
샘플에서 사용하는 uikit-react-native 에서는 main의 cjs 를 사용 -> uikit-tools 의 cjs 사용 -> chat-js의 cjs사용

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.89%. Comparing base (ca6a9a9) to head (8659697).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #270    +/-   ##
========================================
  Coverage   10.89%   10.89%            
========================================
  Files         360      360            
  Lines        9016     9016            
  Branches     2537     2419   -118     
========================================
  Hits          982      982            
  Misses       8033     8033            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title chore: add exports field in package.json for module resolution [CLNP-7712] chore: add exports field in package.json for module resolution Nov 10, 2025
@OnestarLee OnestarLee requested a review from bang9 November 10, 2025 00:55
@OnestarLee OnestarLee force-pushed the chore/add-exports-in-package-json branch from e167f11 to 8659697 Compare November 10, 2025 01:02
@OnestarLee OnestarLee added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit b2fb8c3 Nov 10, 2025
7 checks passed
@OnestarLee OnestarLee deleted the chore/add-exports-in-package-json branch November 10, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants