Commit 2b5f9c0
authored
fix: Donot bundle chat sdk with uikit compiled code (#323)
Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it
Chat SDK should be a dependency of UIKit
Advantages:
* Chat SDK bug fixes will be added for free
* Eliminate the need for handlers
---
So what was the issue:
If you are usig rollup for bundling
in config.external you have to be specific
ie>
This works:
```
external: [
'@sendbird/chat',
'@sendbird/chat/groupChannel',
'@sendbird/chat/openChannel',
'@sendbird/chat/message',
]
```
This doesnt:
```
external: [ '@sendbird/chat', ]
```
fixes: https://sendbird.atlassian.net/browse/UIKIT-22741 parent 1bcbef9 commit 2b5f9c0
1 file changed
+4
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
0 commit comments