Skip to content

Commit 83e8589

Browse files
AhyoungRyuAhyoungRyu
authored
[CLNP-3514] chore: remove onlight05 & ondark05 (#1128)
Addresses https://sendbird.atlassian.net/browse/CLNP-3514 It seems onlight-05 doesn't exist in other platforms and the product designer doesn't even know about the existence of this. So I'm removing and replacing it with onlight-03 instead. https://github.com/sendbird-graveyard/SendBird-UIKIT-JavaScript/tree/master#appendix
1 parent b51beaf commit 83e8589

File tree

12 files changed

+10
-16
lines changed

12 files changed

+10
-16
lines changed

‎src/lib/hooks/useTheme.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,11 @@ const useTheme = (overrides?: Record<string, string>): void => {
103103
'--sendbird-light-onlight-02': 'rgba(0, 0, 0, 0.50)',
104104
'--sendbird-light-onlight-03': 'rgba(0, 0, 0, 0.38)',
105105
'--sendbird-light-onlight-04': 'rgba(0, 0, 0, 0.12)',
106-
'--sendbird-light-onlight-05': 'rgba(0, 0, 0, 0.44)',
107106

108107
'--sendbird-light-ondark-01': 'rgba(255, 255, 255, 0.88)',
109108
'--sendbird-light-ondark-02': 'rgba(255, 255, 255, 0.50)',
110109
'--sendbird-light-ondark-03': 'rgba(255, 255, 255, 0.38)',
111110
'--sendbird-light-ondark-04': 'rgba(255, 255, 255, 0.12)',
112-
'--sendbird-light-ondark-05': 'rgba(255, 255, 255, 0.44)',
113111

114112
'--sendbird-light-shadow-01': '0 1px 5px 0 rgba(33, 34, 66, 0.04), 0 0 3px 0 rgba(0, 0, 0, 0.08), 0 2px 1px 0 rgba(0, 0, 0, 0.12)',
115113
'--sendbird-light-shadow-02': '0 3px 5px -3px rgba(33, 34, 66, 0.04), 0 3px 14px 2px rgba(0, 0, 0, 0.08), 0 8px 10px 1px rgba(0, 0, 0, 0.12)',

‎src/styles/_color-themes.scss‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ $themes: (
4848
on-content-4: var(--sendbird-light-ondark-04),
4949
inverse-on-content-1: var(--sendbird-light-onlight-01),
5050
inverse-on-content-3: var(--sendbird-light-onlight-03),
51-
inverse-on-content-5: var(--sendbird-light-onlight-05),
5251

5352
shadow-gradient-1: var(--sendbird-light-shadow-01),
5453
shadow-gradient-2: var(--sendbird-light-shadow-02),
@@ -128,7 +127,6 @@ $themes: (
128127
on-content-4: var(--sendbird-dark-onlight-04),
129128
inverse-on-content-1: var(--sendbird-dark-ondark-01),
130129
inverse-on-content-3: var(--sendbird-dark-ondark-03),
131-
inverse-on-content-5: var(--sendbird-dark-ondark-05),
132130

133131
shadow-gradient-1: var(--sendbird-dark-shadow-01),
134132
shadow-gradient-2: var(--sendbird-dark-shadow-02),

‎src/styles/_dark-theme.scss‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
--sendbird-dark-ondark-02: rgba(255, 255, 255, 0.50);
4444
--sendbird-dark-ondark-03: rgba(255, 255, 255, 0.38);
4545
--sendbird-dark-ondark-04: rgba(255, 255, 255, 0.12);
46-
--sendbird-dark-ondark-05: rgba(255, 255, 255, 0.44);
4746

4847
--sendbird-dark-shadow-01: 0 1px 5px 0 rgba(33, 34, 66, 0.04), 0 0 3px 0 rgba(0, 0, 0, 0.08), 0 2px 1px 0 rgba(0, 0, 0, 0.12);
4948
--sendbird-dark-shadow-02: 0 3px 5px -3px rgba(33, 34, 66, 0.04), 0 3px 14px 2px rgba(0, 0, 0, 0.08), 0 8px 10px 1px rgba(0, 0, 0, 0.12);

‎src/styles/_light-theme.scss‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
--sendbird-light-onlight-02: rgba(0, 0, 0, 0.50);
3939
--sendbird-light-onlight-03: rgba(0, 0, 0, 0.38);
4040
--sendbird-light-onlight-04: rgba(0, 0, 0, 0.12);
41-
--sendbird-light-onlight-05: rgba(0, 0, 0, 0.44);
4241

4342
--sendbird-light-ondark-01: rgba(255, 255, 255, 0.88);
4443
--sendbird-light-ondark-02: rgba(255, 255, 255, 0.50);

‎src/ui/Icon/colors.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export const Colors = {
66
SECONDARY: 'SECONDARY',
77
CONTENT: 'CONTENT',
88
CONTENT_INVERSE: 'CONTENT_INVERSE',
9-
CONTENT_INVERSE_5: 'CONTENT_INVERSE_5',
9+
CONTENT_INVERSE_3: 'CONTENT_INVERSE_3',
1010
WHITE: 'WHITE',
1111
GRAY: 'GRAY',
1212
THUMBNAIL_ICON: 'THUMBNAIL_ICON',

‎src/ui/Icon/index.scss‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@
4444
}
4545
}
4646

47-
.sendbird-icon-color--content-inverse-5 [class*='fill'] {
47+
.sendbird-icon-color--content-inverse-3 [class*='fill'] {
4848
@include themed() {
49-
fill: t(inverse-on-content-5);
49+
fill: t(inverse-on-content-3);
5050
}
5151
}
5252

‎src/ui/Icon/utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export function changeColorToClassName(color: Colors): string {
88
case Colors.SECONDARY: return 'sendbird-icon-color--secondary';
99
case Colors.CONTENT: return 'sendbird-icon-color--content';
1010
case Colors.CONTENT_INVERSE: return 'sendbird-icon-color--content-inverse';
11-
case Colors.CONTENT_INVERSE_5: return 'sendbird-icon-color--content-inverse-5';
11+
case Colors.CONTENT_INVERSE_3: return 'sendbird-icon-color--content-inverse-3';
1212
case Colors.WHITE: return 'sendbird-icon-color--white';
1313
case Colors.GRAY: return 'sendbird-icon-color--gray';
1414
case Colors.THUMBNAIL_ICON: return 'sendbird-icon-color--thumbnail-icon';

‎src/ui/Label/index.scss‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,9 @@
160160
}
161161
}
162162

163-
.sendbird-label--color-oncontent-inverse-5 {
163+
.sendbird-label--color-oncontent-inverse-3 {
164164
@include themed() {
165-
color: t(inverse-on-content-5);
165+
color: t(inverse-on-content-3);
166166
}
167167
}
168168

‎src/ui/Label/types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const Colors = {
2121
ONCONTENT_1: 'ONCONTENT_1',
2222
ONCONTENT_2: 'ONCONTENT_2',
2323
ONCONTENT_INVERSE_1: 'ONCONTENT_INVERSE_1',
24-
ONCONTENT_INVERSE_5: 'ONCONTENT_INVERSE_5',
24+
ONCONTENT_INVERSE_3: 'ONCONTENT_INVERSE_3',
2525
PRIMARY: 'PRIMARY',
2626
ERROR: 'ERROR',
2727
SECONDARY_3: 'SECONDARY_3',

‎src/ui/Label/utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function changeColorToClassName(color?: ObjectValues<typeof Colors>) {
2828
case Colors.ONCONTENT_1: return 'sendbird-label--color-oncontent-1';
2929
case Colors.ONCONTENT_2: return 'sendbird-label--color-oncontent-2';
3030
case Colors.ONCONTENT_INVERSE_1: return 'sendbird-label--color-oncontent-inverse-1';
31-
case Colors.ONCONTENT_INVERSE_5: return 'sendbird-label--color-oncontent-inverse-5';
31+
case Colors.ONCONTENT_INVERSE_3: return 'sendbird-label--color-oncontent-inverse-3';
3232
case Colors.PRIMARY: return 'sendbird-label--color-primary'; // should be Primary-3 fix me
3333
case Colors.ERROR: return 'sendbird-label--color-error';
3434
case Colors.SECONDARY_3: return 'sendbird-label--color-secondary-3';

0 commit comments

Comments
 (0)