allow localCacheEnabled override through sdkInitParams

Author: AhyoungRyu

src/lib/hooks/useConnect/__test__/setupConnection.spec.ts

@@ -6,6 +6,8 @@ import { getMissingParamError, setUpConnection, initSDK, getConnectSbError } fro
 import { SetupConnectionTypes } from '../types';
 import { generateSetUpConnectionParams, mockSdk, mockUser, mockUser2 } from './data.mocks';
 import { SendbirdError } from '@sendbird/chat';
+import { OpenChannelModule } from '@sendbird/chat/openChannel';
+import { GroupChannelModule } from '@sendbird/chat/groupChannel';
 
 // todo: combine after mock-sdk is implemented
 jest.mock('@sendbird/chat', () => {
@@ -196,10 +198,8 @@ describe('useConnect/setupConnection/initSDK', () => {
       newInstance: false,
       localCacheEnabled: true,
       modules: [
-        // @ts-ignore
-        new (require('@sendbird/chat/groupChannel').GroupChannelModule)(),
-        // @ts-ignore
-        new (require('@sendbird/chat/openChannel').OpenChannelModule)(),
+        GroupChannelModule,
+        OpenChannelModule,
       ],
     });
     expect(newSdk).toEqual(mockSdk);
@@ -215,10 +215,8 @@ describe('useConnect/setupConnection/initSDK', () => {
       newInstance: false,
       localCacheEnabled: true,
       modules: [
-        // @ts-ignore
-        new (require('@sendbird/chat/groupChannel').GroupChannelModule)(),
-        // @ts-ignore
-        new (require('@sendbird/chat/openChannel').OpenChannelModule)(),
+        GroupChannelModule,
+        OpenChannelModule,
       ],
       customApiHost,
       customWebSocketHost,
@@ -236,10 +234,8 @@ describe('useConnect/setupConnection/initSDK', () => {
       newInstance: false,
       localCacheEnabled: true,
       modules: [
-        // @ts-ignore
-        new (require('@sendbird/chat/groupChannel').GroupChannelModule)(),
-        // @ts-ignore
-        new (require('@sendbird/chat/openChannel').OpenChannelModule)(),
+        GroupChannelModule,
+        OpenChannelModule,
       ],
       sdkInitParams,
     });
@@ -256,13 +252,32 @@ describe('useConnect/setupConnection/initSDK', () => {
       newInstance: false,
       localCacheEnabled: true,
       modules: [
-        // @ts-ignore
-        new (require('@sendbird/chat/groupChannel').GroupChannelModule)(),
-        // @ts-ignore
-        new (require('@sendbird/chat/openChannel').OpenChannelModule)(),
+        GroupChannelModule,
+        OpenChannelModule,
       ],
       customExtensionParams,
     });
     expect(newSdk).toEqual(mockSdk);
   });
+  it('should override default localCacheEnabled when provided in sdkInitParams', async () => {
+    const setUpConnectionProps = generateSetUpConnectionParams();
+    const { appId } = setUpConnectionProps;
+    const sdkInitParams = {
+      localCacheEnabled: false,
+    };
+
+    const newSdk = initSDK({ appId, sdkInitParams });
+
+    // @ts-ignore
+    expect(require('@sendbird/chat').init).toBeCalledWith({
+      appId,
+      newInstance: false,
+      modules: [
+        GroupChannelModule,
+        OpenChannelModule,
+      ],
+      localCacheEnabled: false,
+    });
+    expect(newSdk).toEqual(mockSdk);
+  });
 });

src/lib/hooks/useConnect/setupConnection.ts

@@ -173,12 +173,11 @@ export function initSDK({
   sdkInitParams?: SendbirdChatInitParams;
   customExtensionParams?: CustomExtensionParams;
 }) {
-  const params = Object.assign(sdkInitParams, {
-    appId,
-    modules: [new GroupChannelModule(), new OpenChannelModule()],
+  const params = { appId,
+    modules: [GroupChannelModule, OpenChannelModule],
     newInstance: isNewApp,
     localCacheEnabled: true,
-  });
+    ...sdkInitParams };
 
   if (customApiHost) params.customApiHost = customApiHost;
   if (customWebSocketHost) params.customWebSocketHost = customWebSocketHost;