Skip to content

Commit 9e5c757

Browse files
authored
fix: clarify the meaning of isParentMessage (#596)
[UIKIT-4028](https://sendbird.atlassian.net/browse/UIKIT-4028)
1 parent b42668b commit 9e5c757

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/utils/__tests__/isParentMessage.spec.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const mockParentMessage = {
1313
threadInfo: {
1414
lastRepliedAt: 0,
1515
mostRepliedUsers: [],
16-
replyCount: 0,
16+
replyCount: 3,
1717
updatedAt: 0,
1818
},
1919
};
@@ -24,11 +24,18 @@ const mockThreadMessage = {
2424
};
2525

2626
describe('Global-utils/isParentMessage', () => {
27-
it('should verify thread message', () => {
27+
it('should verify parent message', () => {
2828
expect(
2929
isParentMessage(mockParentMessage as unknown as UserMessage),
3030
).toBeTrue();
3131
});
32+
it('should return false when the message does not have replyCount', () => {
33+
const normalMessage = { ...mockParentMessage };
34+
normalMessage.threadInfo.replyCount = 0;
35+
expect(
36+
isParentMessage(normalMessage as unknown as UserMessage),
37+
).toBeFalse();
38+
});
3239
it('should filter the other messages', () => {
3340
expect(
3441
isParentMessage(mockNormalMessage as unknown as UserMessage),

src/utils/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export const isFileMessage = (message: AdminMessage | UserMessage | FileMessage)
137137
message && (message?.isFileMessage?.() || (message?.messageType === 'file'))
138138
);
139139
export const isParentMessage = (message: AdminMessage | UserMessage | FileMessage): boolean => (
140-
!message.parentMessageId && !message.parentMessage && message.threadInfo !== null
140+
!message.parentMessageId && !message.parentMessage && (message.threadInfo?.replyCount ?? 0) > 0
141141
);
142142
export const isThreadMessage = (message: AdminMessage | UserMessage | FileMessage): boolean => (
143143
!!message.parentMessageId && !!message.parentMessage

0 commit comments

Comments
 (0)