Skip to content

Conversation

@aacgn
Copy link

@aacgn aacgn commented Mar 15, 2024

No description provided.

@emilbjorling
Copy link

emilbjorling commented May 30, 2024

@AhyoungRyu Hey! I'm currently fiddling around with this uikit and I've noticed that some query params aren't set properly for the GroupChannelList component as well. Maybe that should be included in this PR too?

As an example:

const [queryParams, setQueryParams] =
    React.useState<GroupChannelListQueryParams>({
      includeEmpty: true,
      channelNameContainsFilter: userId ?? '',
      includeMetaData: true,
    })
<GroupChannelList
    channelListQueryParams={queryParams}
    ...
/>

The metadata field is never added to the API call (even though that it is claimed to be true by default) also some other params are not respected.

This feels like a strange way of reporting a bug, but since the issues tab is disabled for this repo I'm doing it here 😄

@chrisallo
Copy link
Collaborator

I close this because it's now available.

@chrisallo chrisallo closed this Jun 10, 2025
@aacgn aacgn deleted the feat/IFOOD-add-missing-group-channel-list-query-params branch June 10, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants