[CLNP-5045] CreateChannelProvider Migration #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-babel
force-pushed
the
refactor/CLNP-5045/create-channel-migration
branch
from
37cf1d0 to
06171da
Compare
AhyoungRyu
changed the title
chrisallo
reviewed
Nov 14, 2024
| userListQuery, | ||
| } = useCreateChannelContext(); | ||
| state: { | ||
| step, |
Collaborator
There was a problem hiding this comment.
단순 궁금증인데 step 이게 어떤걸 의미하는건가요? 코드를 보니 값이 매직넘버인것같아서 의미가 조금 명확해지도록 개선하면 좋을것 같습니다.
Contributor
There was a problem hiding this comment.
채널 생성화면에서의 스텝을 말하는 것 같습니다.
(1) 생성할 채널 타입 선택
(2) 초대할 유저 선택
저도 동의합니다!
Contributor
Author
There was a problem hiding this comment.
step -> pageStep으로 변경하였습니다.
HoonBaek
approved these changes
Nov 15, 2024
Contributor
HoonBaek
left a comment
HoonBaek
left a comment
There was a problem hiding this comment.
LGTM! Let’s wait for others to review as well
AhyoungRyu
reviewed
Nov 18, 2024
...ules/CreateChannel/components/CreateChannelUI/__tests__/CreateChannelUI.integration.test.tsx
Show resolved
Hide resolved
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AhyoungRyu
approved these changes
Nov 28, 2024
AhyoungRyu
pushed a commit
that referenced
this pull request
Dec 2, 2024
HoonBaek
pushed a commit
that referenced
this pull request
Dec 3, 2024
AhyoungRyu
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://sendbird.atlassian.net/browse/CLNP-5045