refactor: Migrate dispatchers to SMH #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for sendbird-uikit-react failed. Why did it fail? →
|
HoonBaek
force-pushed
the
refactor/CLNP-5736/Migrate-dispatchers-to-SMH
branch
from
e7d8940 to
c57e535
Compare
HoonBaek
commented
Nov 28, 2024
Comment on lines
+15
to
+17
| // TODO: Support below legacy exports | ||
| // useSendbirdStateContext: 'src/hooks/useSendbirdStateContext.tsx', | ||
| // withSendbird: 'src/lib/SendbirdSdkContext.tsx', |
Contributor
Author
There was a problem hiding this comment.
support this in the separated PR
HoonBaek
commented
Nov 28, 2024
Merged
HoonBaek
commented
Nov 28, 2024
HoonBaek
commented
Nov 28, 2024
src/modules/GroupChannelList/context/GroupChannelListProvider.tsx
Outdated
Show resolved
Hide resolved
HoonBaek
commented
Nov 28, 2024
Contributor
Author
There was a problem hiding this comment.
불필요한 파라미터 전달 useSendbird
HoonBaek
commented
Nov 28, 2024
Contributor
Author
There was a problem hiding this comment.
type definition export도 확인하기
HoonBaek
commented
Nov 28, 2024
| if (data.channel.url === currentChannel?.url) scrollPubSub.publish('scrollToBottom', {}); | ||
| }; | ||
|
|
||
| if (pubSub?.subscribe === undefined) return; |
Contributor
Author
There was a problem hiding this comment.
There's a moment that pubSub is undefined when its component is initialized
AhyoungRyu
approved these changes
Nov 28, 2024
from #1256 `sendbird/type` file's location has been moved, so it affected to the every file that uses the type variables related to the Sendbird
HoonBaek
added a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLNP-5736