[CLNP-5914] Fixed a GroupChannel UI error when the Open in Channel action is triggered in a different channel.
#1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
@git-babel Could you elaborate more about what the fix is in the PR description or title? |
git-babel
changed the title
open in channel is clicked in different channel
git-babel
changed the title
open in channel is clicked in different channel
git-babel
changed the title
Open in Channel action is triggered in a different channel.
AhyoungRyu
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Open in Channelaction is triggered in a different channel.Open in Channelimplementation invokes bothsetCurrentChannelandsetStartingPoint. ThesetCurrentChannelfunction triggers asynchronous side effects that updatechannel,messagesDataSource, andstartingPoint. IfsetStartingPointis invoked before these updates are completed, it can result in the channel not being updated correctly or the starting point being improperly set.