[CLNP-5974] Add more GroupChannel module custom hook unit tests #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
git-babel
approved these changes
Dec 4, 2024
chrisallo
approved these changes
Dec 4, 2024
Collaborator
chrisallo
left a comment
chrisallo
left a comment
There was a problem hiding this comment.
lgtm! Please take a quick look at my comment and share your opinion on it.
| await act(async () => { | ||
| result.current.scrollPubSub.publish('scrollToBottom', { resolve: resolveMock }); | ||
| await waitFor(() => { | ||
| expect(resolveMock).toHaveBeenCalled(); |
Collaborator
There was a problem hiding this comment.
Adding some assertion checking current scroll positions would be great here.
AhyoungRyu
added a commit
that referenced
this pull request
Dec 11, 2024
- before <img width="1099" alt="Screenshot 2024-12-03 at 11 14 47 PM" src="https://github.com/user-attachments/assets/75716138-2ac6-46d1-8fe7-d3793d53c3be"> - after <img width="1107" alt="Screenshot 2024-12-03 at 11 13 43 PM" src="https://github.com/user-attachments/assets/182237d5-c322-4d59-8595-3abdaf15afa9"> GroupChannelProvider has some not covered lines but they're mostly from uikit-tools lib related logic. There could be a way to mock these lines too, but let me handle it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupChannelProvider has some not covered lines but they're mostly from uikit-tools lib related logic. There could be a way to mock these lines too, but let me handle it separately.