Skip to content

Add basic test cases for the new ThreadProvider #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AhyoungRyu merged 8 commits into from
Dec 9, 2024
Merged

Add basic test cases for the new ThreadProvider #1274

AhyoungRyu merged 8 commits into from
Dec 9, 2024

Conversation

@git-babel
Copy link
Contributor

@git-babel git-babel commented Dec 5, 2024 •
edited
Loading

Changelog

This PR will add the test cases for the new ThreadProvider and its related hooks.

Before

스크린샷 2024-12-09 오전 11 29 53

After

스크린샷 2024-12-09 오전 11 28 39

@netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 35000c4
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/675653a0809b84000859ca93
😎 Deploy Preview https://deploy-preview-1274--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@git-babel git-babel changed the title Add some basic thread tests Add basic test cases for the new ThreadProvider Dec 5, 2024
@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Dec 5, 2024

Some new tests for these files has been added in here 1fc0c15
Screenshot 2024-12-05 at 5 09 37 PM

@git-babel git-babel removed the in progress Work in progress label Dec 9, 2024
@git-babel
Copy link
Contributor Author

git-babel commented Dec 9, 2024 •
edited
Loading

스크린샷 2024-12-09 오전 11 22 06 The test cases for `useThread` hook are updated.

@AhyoungRyu AhyoungRyu merged commit b9e7602 into feat/state-mgmt-migration-1 Dec 9, 2024
10 checks passed
@AhyoungRyu AhyoungRyu deleted the fix/add_thread_tests branch December 9, 2024 04:04
AhyoungRyu added a commit that referenced this pull request Dec 11, 2024
@git-babel @AhyoungRyu
Add basic test cases for the new ThreadProvider (#1274)
6f0e194 
### Changelog
This PR will add the test cases for the new `ThreadProvider` and its
related hooks.
#### Before
<img width="1163" alt="스크린샷 2024-12-09 오전 11 29 53"
src="https://github.com/user-attachments/assets/40ffc29e-0774-4ac7-973d-15af55bc88fd">

#### After
<img width="1199" alt="스크린샷 2024-12-09 오전 11 28 39"
src="https://github.com/user-attachments/assets/ea3366c0-2f11-4e1f-af6f-a423d006ab42">

---------

Co-authored-by: Irene Ryu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhyoungRyu AhyoungRyu AhyoungRyu approved these changes

@HoonBaek HoonBaek Awaiting requested review from HoonBaek

Assignees

@AhyoungRyu AhyoungRyu

@git-babel git-babel

Labels

provider_migration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@git-babel @AhyoungRyu