Skip to content

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Dec 5, 2024

CLNP-5737

  • Added tests for Sendbird/index.tsx, Sendbird/utils.ts, SendbirdProvider.tsx, initialState.ts, and useSendbird.tsx

Before

image

After

image

@HoonBaek HoonBaek requested a review from git-babel December 5, 2024 11:40
@HoonBaek HoonBaek self-assigned this Dec 5, 2024
@netlify
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit e19f399
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/675259f5dffe0000081f44d4
😎 Deploy Preview https://deploy-preview-1275--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HoonBaek HoonBaek requested a review from AhyoungRyu December 5, 2024 11:43
Copy link
Contributor

@AhyoungRyu AhyoungRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the dir name from tests to __tests__ to keep the consistency?

@HoonBaek HoonBaek requested a review from AhyoungRyu December 6, 2024 02:00
@HoonBaek HoonBaek merged commit 5b35b02 into feat/state-mgmt-migration-1 Dec 6, 2024
10 checks passed
@HoonBaek HoonBaek deleted the chore/CLNP-5737/Add-tests-for-SendbirdProvider branch December 6, 2024 02:13
AhyoungRyu pushed a commit that referenced this pull request Dec 11, 2024
[CLNP-5737](https://sendbird.atlassian.net/browse/CLNP-5737)

* Added tests for `Sendbird/index.tsx`, `Sendbird/utils.ts`,
`SendbirdProvider.tsx`, `initialState.ts`, and `useSendbird.tsx`

### Before

![image](https://github.com/user-attachments/assets/0bdae22e-f5f5-4880-949c-33ea65d61a29)

### After

![image](https://github.com/user-attachments/assets/b0f6d021-bb80-49cd-b476-cc5a6c155c3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants