fix(channel): show members as titles by default for AI Chatbot Widget Channel #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | d446788 |
aldenquimby
commented
Dec 5, 2024
| return stringSet.NO_TITLE; | ||
| } | ||
| if (channel?.name && channel.name !== 'Group Channel') { | ||
| if (channel?.name && channel.name !== 'Group Channel' && channel.name !== 'AI Chatbot Widget Channel') { |
Author
There was a problem hiding this comment.
Here is the primary fix. The rest of the PR is getting all consumers to use a single getChannelTitle helper function
aldenquimby
commented
Dec 5, 2024
| <PlaceHolder | ||
| type={PlaceHolderTypes.SEARCH_IN} | ||
| searchInString={getChannelName()} | ||
| searchInString={getChannelTitle(currentChannel, '', stringSet)} |
Author
There was a problem hiding this comment.
I wasn't sure if it'd be safe to add this hook to this component:
const state = useSendbirdStateContext();
const userId = state?.config?.userId;(passing userId = '' should be safe if that hook is no good... it'd mean no behavior change here - the prior getChannelName function was already not incorporating currentUserId when joining members)
Contributor
|
@aldenquimby Thank you for your PR. But as you said, we don't accept the external contribution. Instead, we made the fix for this issue. The fix will be included in next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you cannot accept PRs from External Contributions.
I just filed a support ticket for this, and am creating a PR to show how I think it could be addressed
Here is what things look like before the PR:
And after:
The idea is that for AI Chatbot generated channels, we should display the name of the chatbot, rather than the default generated
AI Chatbot Widget Channel. And only display the channel name if someone as modified it to something custom