[CLNP-6032]Display members' name instead of default AI chatbot channel name #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AhyoungRyu
reviewed
Dec 12, 2024
|
|
||
| const channelName = useMemo(() => { | ||
| if (channel?.name && channel.name !== 'Group Channel') { | ||
| if (channel?.name && channel.name !== 'Group Channel' && channel.name !== 'AI Chatbot Widget Channel') { |
Contributor
There was a problem hiding this comment.
Let's manage this AI Chatbot Widget Channel string separately in somewhere else so we don't need to compare the string directly every time.
Contributor
There was a problem hiding this comment.
Also, shall we create a separate util function for getting this condition ?
if (channel?.name && channel.name !== 'Group Channel' && channel.name !== 'AI Chatbot Widget Channel') {
Contributor
Author
There was a problem hiding this comment.
isDefaultChannelName() is added in src/utils/index.ts. Also, DEFAULT_GROUP_CHANNEL_NAME and DEFAULT_AI_CHATBOT_CHANNEL_NAME are introduced too. But those consts are only used in isDefaultChannelName() for now.
AhyoungRyu
reviewed
Dec 12, 2024
Contributor
AhyoungRyu
left a comment
AhyoungRyu
left a comment
There was a problem hiding this comment.
Same comments for other files.
src/modules/ChannelSettings/components/ChannelProfile/index.tsx
Outdated
Show resolved
Hide resolved
AhyoungRyu
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sendbird.atlassian.net/browse/CLNP-6032
Changelog
Group Channeldoes.