[CLNP-6022] Memoize useGroupChannel actions to prevent unnecessary re-rendering #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AhyoungRyu
commented
Dec 16, 2024
Contributor
Author
There was a problem hiding this comment.
Just wrapped all handlers with useCallback one by one. No logic changes.
AhyoungRyu
commented
Dec 16, 2024
| */ | ||
| return false; | ||
| } | ||
| return !isEqual(prevState[key as keyof T], value); |
Contributor
Author
There was a problem hiding this comment.
Changed the way of comparing prev <-> next state with isEqual for deeper comparison like useDeepCompareEffect
HoonBaek
approved these changes
Dec 16, 2024
src/modules/GroupChannel/components/MessageList/InfiniteList.tsx
Outdated
Show resolved
Hide resolved
AhyoungRyu
force-pushed
the
fix/CLNP-6022-2
branch
from
f9168a0 to
c1f6bab
Compare
Contributor
|
I think it's good to merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://sendbird.atlassian.net/browse/CLNP-6022?focusedCommentId=301263
Key changes
Memoized action handlers(+ scroll related functions as well) in useGroupChannel to reduced unnecessary re-rendering.