fix: search messages with messageSearchQuery #1292
Closed
+97
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for sendbird-uikit-react pending review.Visit the deploys page to approve it
|
Contributor
|
Thank you for your interest in our library. @sasha1107 |
Contributor
HoonBaek
added a commit
that referenced
this pull request
Jan 23, 2025
Made from #1292 Thanks to @sasha1107 ### Changelog * Also use the `messageSearchQuery.keyword` when searching in MessageSearch module * Note: The `searchString` has higher priority, P0: `searchString`, P1: `messageSearchQuery.keyword`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details of the pull request I am proposing involve using messageSearchParams to provide to the messageSearchProvider. Currently, there is no way to input a messageSearchQuery without a searchString.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.