Skip to content

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Jan 8, 2025

Description

Issue

  • In this PR, the memoization of actions using useCallback caused an issue that doesn't make necessary component re-render.

Fix

  • So I revert that change

Related issues

@netlify
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 8e0b95f
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/677e0f2480216e0008a7df5d
😎 Deploy Preview https://deploy-preview-1293--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@git-babel
Copy link
Contributor

In my local environment, the issue still occurs (ex: https://sendbird.atlassian.net/browse/CLNP-6089)

@HoonBaek HoonBaek self-assigned this Jan 10, 2025
@HoonBaek
Copy link
Contributor Author

#1298

@HoonBaek HoonBaek closed this Jan 10, 2025
@bang9 bang9 deleted the fix/revert-actions-memoization-with-callback branch November 7, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants