Add minor util tests #1294
Merged
Add minor util tests #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HoonBaek
reviewed
Jan 8, 2025
src/utils/color.ts
Outdated
| case Colors.ONBACKGROUND_3: return 'sendbird-color--onbackground-3'; | ||
| case Colors.ONBACKGROUND_4: return 'sendbird-color--onbackground-4'; | ||
| case Colors.ONCONTENT_1: return 'sendbird-color--oncontent-1'; | ||
| case Colors.ONCONTENT_2: return 'sendbird-color--oncontent-2'; |
Contributor
There was a problem hiding this comment.
If we use the ONCONTENT_2, we need CSS set too. But it seems there's no CSS files for this className.
Contributor
Author
There was a problem hiding this comment.
As you said, we have a logic to convert the enum value to the class name, but there is no actual css for sendbird-color--oncontent-2. Should we delete the logic and test for Colors.ONCONTENT_2?
Contributor
There was a problem hiding this comment.
Yes, I think it's good to remove it. We can always add it back when needed.
HoonBaek
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog