[SBISSUE-18637] Create store with the props as a default value #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisallo
reviewed
Feb 26, 2025
| * Create store for Sendbird context | ||
| */ | ||
| export const createSendbirdContextStore = () => createStore(initialState); | ||
| export const createSendbirdContextStore = (props?: any) => createStore({ |
Collaborator
There was a problem hiding this comment.
여기 props 타입을 PartialDeep<SendbirdState>로 하는건 어떤가요?
Contributor
Author
There was a problem hiding this comment.
비슷한 부분들 일괄 수정했습니다.
SendbirdContextStore를 제외한 Store들은 값들을 flat하게 가지고 있기 때문에 굳이 PartialDeep을 사용할 필요가 없어 Partial로 대체했습니다.
SendbirdContextStore의 경우 PartialDeep을 사용하게 되면 scrollRef와 같이 object를 value로 가질 경우 이 모두 optional로 취급되어 타입 에러가 발생합니다. 따라서 현재 SendbirdState의 구조에 맞춰 TwoDepthPartial을 추가했습니다.
Contributor
Author
There was a problem hiding this comment.
다만 코드 미관상으로 그렇게 좋지는 않은 것 같습니다. 수정할 부분 있으면 말씀주세요.
Collaborator
There was a problem hiding this comment.
빠르게 도입할 수 있는 대안이 없는것같아서 일단 고 하시죠ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
SBISSUE-18637
Changelog