Skip to content

[CLNP-6496] Support multiline ellipsis of quoted message #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-babel merged 1 commit into from
Apr 9, 2025
Merged

[CLNP-6496] Support multiline ellipsis of quoted message #1326

git-babel merged 1 commit into from
Apr 9, 2025

Conversation

@git-babel
Copy link
Contributor

@git-babel git-babel commented Apr 8, 2025 •
edited by atlassian bot
Loading

Ticket

CLNP-6496

Changelog

  • Support multiline ellipsis of quoted message.
    • Not all browser supports the added css properties. We try to show ellipsis, but if the environment doesn't support it, we maintain the previous behavior.
    • I expect those properties will be ignored on the unsupported browser. AFAIK, firefox is the only major browser doesn't support the properties.

Screenshot

Before

스크린샷 2025-04-08 오후 4 35 06

After

스크린샷 2025-04-08 오후 4 34 42

@netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 2c1c082
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/67f4d22fa32c7300087f7591
😎 Deploy Preview https://deploy-preview-1326--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@git-babel git-babel requested a review from chrisallo April 8, 2025 07:38
chrisallo
chrisallo approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@git-babel git-babel merged commit ebe4390 into main Apr 9, 2025
10 checks passed
@bang9 bang9 deleted the fix/CLNP-6496 branch November 7, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisallo chrisallo chrisallo approved these changes

Assignees

No one assigned

Labels

3.16.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@git-babel @chrisallo