[CLNP-6644] Thread messages are not loaded when the scroll at the top #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisallo
approved these changes
Apr 11, 2025
Collaborator
chrisallo
left a comment
chrisallo
left a comment
There was a problem hiding this comment.
일단 approve는 드렸는데 정확히 어떤 문제인지 궁금해서ㅎㅎ 간단하게 설명을 부탁드려도 될까요?
Contributor
Author
|
@chrisallo 스레드 메시지를 가져올 때 초기에는 최신순으로 30개를 가져오는데, 그 이후에 스크롤을 올려서 top까지 가도 이전 메시지를 fetch하지 않는 버그가 있었습니다. 원인은 useThread의 fetchPrev가 threadListState에 의존성을 가지고 있었는데 상위 레벨에서 이 의존성을 제대로 추가해주지 않았습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CLNP-6644
Changelog