Skip to content

[CLNP-6660] Check memoization of custom hooks' actions #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-babel merged 9 commits into from
Apr 24, 2025
Merged

[CLNP-6660] Check memoization of custom hooks' actions #1331

git-babel merged 9 commits into from
Apr 24, 2025

Conversation

@git-babel
Copy link
Contributor

@git-babel git-babel commented Apr 22, 2025 •
edited by atlassian bot
Loading

Ticket

CLNP-6660

@git-babel git-babel requested a review from chrisallo April 22, 2025 08:31
@netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 148460f
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/6809bfc4ee64dd0008578902
😎 Deploy Preview https://deploy-preview-1331--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chrisallo
chrisallo reviewed Apr 22, 2025
View reviewed changes
@git-babel
Copy link
Contributor Author

git-babel commented Apr 23, 2025

@chrisallo store를 사용하는 useCallback들의 deps에 store 추가하고, 누락되었던 useSendbird.tsx 파일 추가해서 커밋했습니다.

chrisallo
chrisallo approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@git-babel git-babel merged commit 244425a into main Apr 24, 2025
10 checks passed
@bang9 bang9 deleted the feature/CLNP-6660/check_custom_hook_memoization branch November 7, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisallo chrisallo chrisallo approved these changes

Assignees

No one assigned

Labels

3.16.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@git-babel @chrisallo