Skip to content

Conversation

@chrisallo
Copy link
Collaborator

@chrisallo chrisallo commented Jun 5, 2025

[fix]: No mark as delivered if disableMarkAsDelivered is set to true

Fixes CLNP-6874

Changelogs

  • Fixed a bug that channel is marked as delivered with disableMarkAsDelivered set to true

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

@chrisallo chrisallo requested a review from danney-chun June 5, 2025 19:26
@chrisallo chrisallo self-assigned this Jun 5, 2025
@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit e9e4034
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6841ef6405e5620007b5c4fe
😎 Deploy Preview https://deploy-preview-1340--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@danney-chun danney-chun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@chrisallo chrisallo merged commit d3f9c3c into main Jun 9, 2025
10 checks passed
@bang9 bang9 deleted the fix/clnp-6874 branch November 7, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants