Fixed bug reaction is not updated in ThreadList #1367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where reactions were not being updated in the ThreadList component. The issue was caused by the reaction update handler not properly checking if the reaction event belonged to the current channel before processing it.
- Added channel URL comparison to ensure reaction updates only apply to the current channel
- Modified the useMemo dependency to trigger re-renders when reactions change
- Added testing configuration to enable thread reply functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/Thread/context/useThread.ts | Modified useMemo to trigger re-renders on reaction updates |
| src/modules/Thread/context/hooks/useHandleChannelEvents.ts | Added channel URL validation for reaction update events |
| apps/testing/src/pages/PlaygroundPage.tsx | Configured testing app to use thread reply mode |
| .github/workflows/package-publish.yml | Added npm package publication verification step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Apply to #1369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix]: Fix a bug where reactions are not updated in ThreadList
Fixes CLNP-7553
Changelogs
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.