Skip to content

Conversation

@danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Oct 1, 2025

[fix]: Fixed RQA Issue

Fixes CLNP-7007
Fixes CLNP-7553

Changelogs

  • Fixed a bug where failed message can't be resend
  • Fixed a bug where Reaction is not updated in Thread

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@netlify
Copy link

netlify bot commented Oct 1, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 8e20267
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/68de2547066fc600080e5967
😎 Deploy Preview https://deploy-preview-1369--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danney-chun danney-chun self-assigned this Oct 1, 2025
@danney-chun danney-chun requested a review from Copilot October 1, 2025 02:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two main issues: a bug preventing failed messages from being resent and a bug where reactions weren't properly updating in the Thread view. The changes improve message state management and reaction handling in threaded conversations.

  • Fixed failed message resend functionality by adding proper sendingStatus updates and resendMessage support
  • Fixed reaction updates in Thread view by ensuring proper state mutations and array reference updates
  • Updated thread message initialization logic and added inclusive parameter for better message fetching

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/utils/storeManager.ts Added array shallow comparison optimization for state change detection
src/modules/Thread/context/useThread.ts Fixed sendingStatus updates and reaction handling with proper state mutations
src/modules/Thread/context/hooks/useThreadFetchers.ts Added isInclusive parameter for thread message fetching
src/modules/Thread/components/ThreadList/ThreadListItemContent.tsx Added resendMessage prop to enable failed message resending
src/modules/GroupChannel/components/MessageList/index.tsx Added null check for currentChannel.myLastRead
src/modules/Channel/context/hooks/useHandleChannelEvents.ts Added channel type check for reaction events and removed TODO comment
package.json Updated Sendbird dependencies to newer versions
apps/testing/src/pages/PlaygroundPage.tsx Added thread reply type configuration for testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@danney-chun danney-chun mentioned this pull request Oct 1, 2025
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danney-chun danney-chun merged commit 7a85726 into main Oct 2, 2025
10 checks passed
@bang9 bang9 deleted the origin/bug-fix/CLNP-7007 branch November 7, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants