-
Notifications
You must be signed in to change notification settings - Fork 143
Fixed a bug where Failed message can't be send #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two main issues: a bug preventing failed messages from being resent and a bug where reactions weren't properly updating in the Thread view. The changes improve message state management and reaction handling in threaded conversations.
- Fixed failed message resend functionality by adding proper sendingStatus updates and resendMessage support
- Fixed reaction updates in Thread view by ensuring proper state mutations and array reference updates
- Updated thread message initialization logic and added inclusive parameter for better message fetching
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/storeManager.ts | Added array shallow comparison optimization for state change detection |
| src/modules/Thread/context/useThread.ts | Fixed sendingStatus updates and reaction handling with proper state mutations |
| src/modules/Thread/context/hooks/useThreadFetchers.ts | Added isInclusive parameter for thread message fetching |
| src/modules/Thread/components/ThreadList/ThreadListItemContent.tsx | Added resendMessage prop to enable failed message resending |
| src/modules/GroupChannel/components/MessageList/index.tsx | Added null check for currentChannel.myLastRead |
| src/modules/Channel/context/hooks/useHandleChannelEvents.ts | Added channel type check for reaction events and removed TODO comment |
| package.json | Updated Sendbird dependencies to newer versions |
| apps/testing/src/pages/PlaygroundPage.tsx | Added thread reply type configuration for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…rd-uikit-react into origin/bug-fix/CLNP-7007
bang9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
[fix]: Fixed RQA Issue
Fixes CLNP-7007
Fixes CLNP-7553
Changelogs
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.