From bc32d59c13667d2ac741e304c32c6e7205ada505 Mon Sep 17 00:00:00 2001 From: "junyoung.lim" Date: Thu, 10 Apr 2025 18:16:49 +0900 Subject: [PATCH 1/3] Add missing deps list elements --- src/modules/Thread/context/useThread.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/modules/Thread/context/useThread.ts b/src/modules/Thread/context/useThread.ts index 7cf276719..853c4c232 100644 --- a/src/modules/Thread/context/useThread.ts +++ b/src/modules/Thread/context/useThread.ts @@ -537,6 +537,9 @@ const useThread = () => { currentChannel, stores.sdkStore.initialized, parentMessage, + threadListState, + isReactionEnabled, + logger, ]); return { state, actions }; From aab45253fc59375363e49fe42f5cafc990009508 Mon Sep 17 00:00:00 2001 From: "junyoung.lim" Date: Tue, 15 Apr 2025 15:58:08 +0900 Subject: [PATCH 2/3] Add missing dependency 'scrollToBottom' --- src/modules/GroupChannel/context/hooks/useMessageActions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/GroupChannel/context/hooks/useMessageActions.ts b/src/modules/GroupChannel/context/hooks/useMessageActions.ts index d2d6d8958..d10e17568 100644 --- a/src/modules/GroupChannel/context/hooks/useMessageActions.ts +++ b/src/modules/GroupChannel/context/hooks/useMessageActions.ts @@ -102,7 +102,7 @@ export function useMessageActions(params: Params): MessageActions { () => { setTimeout(scrollToBottom, 0); }, - [], + [scrollToBottom], ); const processParams = useCallback(async ( From 6a3ffdfdf50f76382166e0f1083b675f7835f0c9 Mon Sep 17 00:00:00 2001 From: "junyoung.lim" Date: Tue, 15 Apr 2025 16:13:43 +0900 Subject: [PATCH 3/3] Remove unnecessary delay in `scrollToBottom` callback --- src/modules/GroupChannel/context/hooks/useGroupChannel.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/modules/GroupChannel/context/hooks/useGroupChannel.ts b/src/modules/GroupChannel/context/hooks/useGroupChannel.ts index 445bcbe2f..591507658 100644 --- a/src/modules/GroupChannel/context/hooks/useGroupChannel.ts +++ b/src/modules/GroupChannel/context/hooks/useGroupChannel.ts @@ -19,7 +19,6 @@ import useSendbird from '../../../../lib/Sendbird/context/hooks/useSendbird'; import { GroupChannelContext } from '../GroupChannelProvider'; import type { GroupChannelState, MessageActions } from '../types'; import { useMessageActions } from './useMessageActions'; -import { delay } from '../../../../utils/utils'; export interface GroupChannelActions extends MessageActions { // Channel actions @@ -71,8 +70,6 @@ export const useGroupChannel = () => { setAnimatedMessageId(null); setIsScrollBottomReached(true); - // wait a bit for scroll ref to be updated - await delay(); if (config.isOnline && state.hasNext()) { await state.resetWithStartingPoint(Number.MAX_SAFE_INTEGER); }