You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CHANGELOG.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -215,11 +215,11 @@ All notable changes to this project will be documented in this file.
215
215
-[PR #518](https://github.com/sendgrid/sendgrid-csharp/pull/518) README improvements. Big thanks to [Matt Bernier](https://github.com/mbernier) for the PR!
216
216
217
217
## Fixed
218
-
-[PR #735](https://github.com/sendgrid/sendgrid-csharp/pull/735) Fix #418 groupsToDisplay shold be optional.
219
-
-[PR #719](https://github.com/sendgrid/sendgrid-csharp/pull/719) Update travis config to use relative path. Big thanks to [Maxim Rubis](https://github.com/siburny) for the PR!
218
+
-[PR #735](https://github.com/sendgrid/sendgrid-csharp/pull/735) Fix #418 groupsToDisplay should be optional.
219
+
-[PR #719](https://github.com/sendgrid/sendgrid-csharp/pull/719) Update travis config to use a relative path. Big thanks to [Maxim Rubis](https://github.com/siburny) for the PR!
220
220
-[PR #702](https://github.com/sendgrid/sendgrid-csharp/pull/702) Fixed virtual bug. Big thanks to [Phil](https://github.com/psboies) for the PR!
221
221
-[PR #700](https://github.com/sendgrid/sendgrid-csharp/pull/700) Add default value for SubstitutionTag parameter. Big thanks to [Vedant Koditkar](https://github.com/KoditkarVedant) for the PR!
222
-
-[PR #688](https://github.com/sendgrid/sendgrid-csharp/pull/688) Fix mixup of Response.Body and Response.Header summarie. Big thanks to [Ryan David Sheasb](https://github.com/ryan27968) for the PR!
222
+
-[PR #688](https://github.com/sendgrid/sendgrid-csharp/pull/688) Fix mixup of Response.Body and Response.Header summary. Big thanks to [Ryan David Sheasb](https://github.com/ryan27968) for the PR!
223
223
-[PR #635](https://github.com/sendgrid/sendgrid-csharp/pull/635) Fixed "Variable assigned but never used" issue. Big thanks to [Unlocked](https://github.com/TheUnlocked) for the PR!
224
224
-[PR #615](https://github.com/sendgrid/sendgrid-csharp/pull/615) Update USAGE.md - fix typo. Big thanks to [Anvesh Chaturvedi](https://github.com/anveshc05) for the PR!
225
225
-[PR #613](https://github.com/sendgrid/sendgrid-csharp/pull/613) Update CONTRIBUTING.md - fix typo. Big thanks to [thepriefy](https://github.com/thepriefy) for the PR!
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -13,7 +13,7 @@ All third party contributors acknowledge that any contributions they provide wil
13
13
-[Code Reviews](#code-reviews)
14
14
15
15
<aname="roadmap"></a>
16
-
We use [GitHub Projects](https://github.com/sendgrid/sendgrid-csharp/projects) to help define current roadmaps, please feel free to grab an issue from our [GitHub Issues](https://github.com/sendgrid/sendgrid-csharp/issues). Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
16
+
We use [GitHub Projects](https://github.com/sendgrid/sendgrid-csharp/projects) to help define current roadmaps, please feel free to grab an issue from our [GitHub Issues](https://github.com/sendgrid/sendgrid-csharp/issues). Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions, and additional PRs are welcomed and encouraged.
17
17
18
18
There are a few ways to contribute, which we'll enumerate below:
19
19
@@ -36,8 +36,8 @@ A software bug is a demonstrable issue in the code base. In order for us to diag
36
36
37
37
Before you decide to create a new issue, please try the following:
38
38
39
-
1. Check the Github issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
40
-
2. Update to the latest version of this code and check if issue has already been fixed
39
+
1. Check the GitHub issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
40
+
2. Update to the latest version of this code and check if the issue has already been fixed
41
41
3. Copy and fill in the Bug Report Template we have provided below
42
42
43
43
### Please use our Bug Report Template
@@ -132,7 +132,7 @@ Generally, we follow the style guidelines as suggested by the official language.
132
132
git pull upstream <dev-branch>
133
133
```
134
134
135
-
3. Create a new topic branch off the `development` branch to
135
+
3. Create a new topic branch (off the main project development branch) to
136
136
contain your feature, change, or fix:
137
137
138
138
```bash
@@ -167,4 +167,4 @@ Generally, we follow the style guidelines as suggested by the official language.
167
167
<aname="code-reviews"></a>
168
168
## Code Reviews
169
169
170
-
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great information on how to review a Pull Request.
170
+
If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how GitHub has some great information on how to review a Pull Request.
**The Twilio SendGrid C# .NET library provide an easy way to send emails. This example application shows how to integrate with an ASP.NET application.**
1
+
**The Twilio SendGrid C# .NET library provides an easy way to send emails. This example application shows how to integrate with an ASP.NET application.**
2
2
3
3
# Installation
4
4
@@ -7,20 +7,20 @@
7
7
- .NET version 4.5.2 and higher
8
8
- Visual Studio 2015
9
9
10
-
## Setup Environment Variables
10
+
## Setup Environment Variables
11
11
12
12
Update the "SendGridApiKey" appSettings variable within the web.config file.
13
13
14
14
## Steps
15
15
16
16
1. Open SendGrid.ASPSamples.sln
17
-
2. Switch to one of the example project (rightclick on a project -> "Set as StartUp project")
18
-
2. Build and run the project
17
+
2. Switch to one of the example project (right-click on a project -> "Set as StartUp project")
18
+
3. Build and run the project
19
19
20
-
You may need to download the latest Nuget executable and run `nuget.exe restore`
20
+
You may need to download the latest Nuget executable and run `nuget.exe restore`
21
21
22
-
3. When you run the project, a web form will launch in your browser that will send an email.
22
+
4. When you run the project, a web form will launch in your browser that will send an email.
23
23
24
24
## Happy coding
25
25
26
-
Big thanks to [paritosh baghel](https://github.com/paritoshmmmec) for contributing this example code!
26
+
Big thanks to [paritosh baghel](https://github.com/paritoshmmmec) for contributing this example code!
Copy file name to clipboardExpand all lines: TROUBLESHOOTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,4 +1,4 @@
1
-
If you have an issue logging into your Twilio SendGrid account, please read this [document](https://sendgrid.com/docs/ui/account-and-settings/troubleshooting-login/). For any questions regarding login issues, please contact our [support team](https://support.sendgrid.com).
1
+
If you have an issue logging into your Twilio SendGrid account, please read this [document](https://sendgrid.com/docs/ui/account-and-settings/troubleshooting-login/). For any questions regarding login issues, please contact our [support team](https://support.sendgrid.com).
2
2
3
3
If you have a non-library Twilio SendGrid issue, please contact our [support team](https://support.sendgrid.com).
4
4
@@ -48,7 +48,7 @@ becomes
48
48
49
49
`string apiKey = "SENDGRID_API_KEY";`
50
50
51
-
In the first case SENDGRID_API_KEY is in reference to the name of the environment variable, while the second case references the actual Twilio SendGrid API Key.
51
+
In the first case, SENDGRID_API_KEY is in reference to the name of the environment variable, while the second case references the actual Twilio SendGrid API Key.
52
52
53
53
<aname="error"></a>
54
54
## Error Messages
@@ -171,7 +171,7 @@ In most cases we recommend you download the latest version of the library, but i
171
171
<aname="versioning"></a>
172
172
## Versioning Convention
173
173
174
-
We follow the MAJOR.MINOR.PATCH versioning scheme as described by [SemVer.org](http://semver.org). Therefore, we recommend that you always pin (or vendor) the particular version you are working with to your code and never auto-update to the latest version. Especially when there is a MAJOR point release, since that is guaranteed to be a breaking change. Changes are documented in the [CHANGELOG](CHANGELOG.md) and [releases](https://github.com/sendgrid/sendgrid-csharp/releases) section.
174
+
We follow the MAJOR.MINOR.PATCH versioning scheme as described by [SemVer.org](http://semver.org). Therefore, we recommend that you always pin (or vendor) the particular version you are working with your code and never auto-update to the latest version. Especially when there is a MAJOR point release since that is guaranteed to be a breaking change. Changes are documented in the [CHANGELOG](CHANGELOG.md) and [releases](https://github.com/sendgrid/sendgrid-csharp/releases) section.
If your UI based requests are failing, it may be due to a little known issue where the UI only has a single thread. The answer here is to use `ConfigureAwait(false)` on the end of your request call, so that the thread does not reset back to request context and stays in capture context. Normally, async the request thread would "let go" of the capture context and reset to request context. With the UI, there is only a single thread, so you have to force the thread to switch to capture context, using `ConfigureAwait(false)`. For more information, please see a better summary that is linked to a longer article [in StackOverflow](https://stackoverflow.com/a/13494570).
190
+
If your UI based requests are failing, it may be due to a little known issue where the UI only has a single thread. The answer here is to use `ConfigureAwait(false)` on the end of your request call so that the thread does not reset back to request context and stays in capture context. Normally, async the request thread would "let go" of the capture context and reset to request context. With the UI, there is only a single thread, so you have to force the thread to switch to capture context, using `ConfigureAwait(false)`. For more information, please see a better summary that is linked to a longer article [in StackOverflow](https://stackoverflow.com/a/13494570).
191
191
192
192
In our example code, you would change:
193
193
@@ -203,4 +203,4 @@ var response = await client.SendEmailAsync(msg).ConfigureAwait(false);
203
203
204
204
If you are running a newer versions of .NET you can turn on a couple different Roslyn based analyzers that will trigger build errors if you're not calling `.ConfigureAwait(false)` on your async methods.
205
205
206
-
`Roslynator.Analyzers` can be installed through NuGet or as a VS plugin, but if you use the plugin then the analyzers won't run on build servers and trigger build errors like the NuGet package would. (thanks to [xt0rted](https://github.com/xt0rted) for this tip!)
206
+
`Roslynator.Analyzers` can be installed through NuGet or as a VS plugin, but if you use the plugin then the analyzers won't run on build servers and trigger build errors as the NuGet package would. (thanks to [xt0rted](https://github.com/xt0rted) for this tip!)
0 commit comments