Skip to content

Commit 44e7b76

Browse files
committed
🐛 Fix method signatures with NimBLE library
1 parent a65b023 commit 44e7b76

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

.github/workflows/arduino-ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
- "esp32:esp32:esp32s3"
3333
- "esp32:esp32:esp32c3"
3434
nimble: [ false, true ]
35+
fail-fast: false
3536

3637
steps:
3738
- uses: actions/checkout@v4

examples/SerialToSerialBLE/SerialToSerialBLE.ino

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
String device_name = "ESP32-BLE-Slave";
99

10+
// Mind the empty template argument (<>), it is required for
11+
// the code to compile with the current Arduino C++ compiler version
1012
BLESerial<> SerialBLE;
1113

1214
// FOR ETL: Uncomment one of the following lines

src/BLESerial.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,11 @@ class BLESerialServerCallbacks : public BLEServerCallbacks {
262262
public:
263263
explicit BLESerialServerCallbacks(BLESerial<T>* bleSerial) : bleSerial(bleSerial) {}
264264

265+
#if defined(BLESERIAL_USE_NIMBLE) && BLESERIAL_USE_NIMBLE
266+
void onDisconnect(NimBLEServer* pServer, NimBLEConnInfo& connInfo, int reason) override
267+
#else
265268
void onDisconnect(BLEServer* pServer) override
269+
#endif
266270
{
267271
auto* pAdvertising = pServer->getAdvertising();
268272
if (pAdvertising == nullptr) {

0 commit comments

Comments
 (0)