fix: remove storybook:generate-preview command

Author: jon-ht

src/Command/GeneratePreviewCommand.php

@@ -6,7 +6,6 @@
 use Storybook\Attributes\AsArgsProcessor;
 use Storybook\Attributes\AsComponentMock;
 use Storybook\CacheWarmer\StorybookCacheWarmer;
-use Storybook\Command\GeneratePreviewCommand;
 use Storybook\Command\StorybookInitCommand;
 use Storybook\Controller\StorybookController;
 use Storybook\Controller\StorybookPreviewController;
@@ -152,13 +151,6 @@ static function (ChildDefinition $definition, AsComponentMock $attributeInstance
         $container->register('storybook.component_proxy_factory', ComponentProxyFactory::class)
             ->setArgument(0, new AbstractArgument(\sprintf('Provided in "%s".', ComponentMockPass::class)));
 
-        // Internal commands
-        $container->register('storybook.generate_preview_command', GeneratePreviewCommand::class)
-            ->setArgument(0, new Reference('twig'))
-            ->setArgument(1, new Reference('event_dispatcher'))
-            ->addTag('console.command', ['name' => 'storybook:generate-preview'])
-        ;
-
         // Init command
         $container->register('storybook.init_command', StorybookInitCommand::class)
             ->setArgument(0, $container->getParameter('kernel.project_dir'))

src/DependencyInjection/StorybookExtension.php

@@ -56,7 +56,9 @@ type SymfonyOptions = {
     additionalWatchPaths?: string[];
     /**
      * When Storybook and Symfony are not on the same host (e.g. Symfony is Dockerized), mounted paths may differ.
-     * This option allows to map paths from Symfony host to Storybook host.
+     * This option allows to map paths from Storybook host to Symfony host.
+     *
+     * Example: { __dirname: '/var/www' }
      */
     templatePathAliases?: {
         [p: string]: string;

storybook/dist/index.d.mts

@@ -56,7 +56,9 @@ type SymfonyOptions = {
     additionalWatchPaths?: string[];
     /**
      * When Storybook and Symfony are not on the same host (e.g. Symfony is Dockerized), mounted paths may differ.
-     * This option allows to map paths from Symfony host to Storybook host.
+     * This option allows to map paths from Storybook host to Symfony host.
+     *
+     * Example: { __dirname: '/var/www' }
      */
     templatePathAliases?: {
         [p: string]: string;

storybook/dist/index.d.ts

@@ -0,0 +1,26 @@
+<?php
+
+namespace Storybook\Tests\Functional\Controller;
+
+use Storybook\Tests\StoryTestTrait;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\DomCrawler\Crawler;
+
+class StorybookPreviewControllerTest extends WebTestCase
+{
+    use StoryTestTrait;
+
+    public function testPreview()
+    {
+        $client = static::createClient();
+        $client->request('GET', '_storybook/preview');
+
+        $this->assertResponseIsSuccessful();
+
+        // Check that the preview contains the basic HTML structure
+        $this->assertSelectorExists('html');
+        $this->assertSelectorExists('head');
+        $this->assertSelectorExists('body');
+    }
+}

storybook/dist/server/framework-preset.js

@@ -0,0 +1,33 @@
+<?php
+
+namespace Storybook\Tests\Unit\Controller;
+
+use PHPUnit\Framework\TestCase;
+use Storybook\Controller\StorybookPreviewController;
+use Storybook\Event\GeneratePreviewEvent;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+use Symfony\Component\HttpFoundation\Response;
+use Twig\Environment;
+
+class StorybookPreviewControllerTest extends TestCase
+{
+    public function testControllerReturnsResponse()
+    {
+        $twig = $this->createMock(Environment::class);
+        $eventDispatcher = $this->createMock(EventDispatcherInterface::class);
+
+        $controller = new StorybookPreviewController($twig, $eventDispatcher);
+
+        $twig->expects($this->once())
+            ->method('render')
+            ->with('@Storybook/preview.html.twig')
+            ->willReturn('');
+
+        $eventDispatcher
+            ->expects($this->once())
+            ->method('dispatch')
+            ->with($this->isInstanceOf(GeneratePreviewEvent::class));
+
+        $this->assertInstanceOf(Response::class, $controller());
+    }
+}