Skip to content

Commit a017fef

Browse files
author
shengyonggen
committed
修复点击target是document导致的异常,增加对非纯数字id的处理
1 parent db89388 commit a017fef

File tree

7 files changed

+40
-22
lines changed

7 files changed

+40
-22
lines changed

sensorsdata.amd.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sensorsdata.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/sdk.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1538,11 +1538,11 @@ _.querySelectorAll = function(val){
15381538
// 替换纯数字的id
15391539
var sp = val.split(' ');
15401540
if(sp.length === 1){
1541-
if(/^#\d+$/.test(sp[0])){
1541+
if(/^#\d+/.test(sp[0])){
15421542
val = '#' + _.strToUnicode(sp[0].slice(1));
15431543
}
15441544
}else{
1545-
if(/^#\d+$/.test(sp[0])){
1545+
if(/^#\d+/.test(sp[0])){
15461546
sp[0] = '#' + _.strToUnicode(sp[0].slice(1));
15471547
val = sp.join(' ');
15481548
}
@@ -3098,7 +3098,10 @@ saEvent.send = function(p, callback) {
30983098
return false;
30993099
}
31003100
var target = ev.target || ev.srcElement;
3101-
if(!target){
3101+
if(typeof target !== 'object'){
3102+
return false;
3103+
}
3104+
if(typeof target.tagName !== 'string'){
31023105
return false;
31033106
}
31043107
var tagName = target.tagName.toLowerCase();
@@ -3123,7 +3126,10 @@ saEvent.send = function(p, callback) {
31233126
return false;
31243127
}
31253128
var target = ev.target || ev.srcElement;
3126-
if(!target){
3129+
if(typeof target !== 'object'){
3130+
return false;
3131+
}
3132+
if(typeof target.tagName !== 'string'){
31273133
return false;
31283134
}
31293135
var tagName = target.tagName.toLowerCase();

src/sensorsdata.full.amd.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ var ObjProto = Object.prototype;
144144
var slice = ArrayProto.slice;
145145
var toString = ObjProto.toString;
146146
var hasOwnProperty = ObjProto.hasOwnProperty;
147-
var LIB_VERSION = '1.9.5';
147+
var LIB_VERSION = '1.9.6';
148148

149149
sd.lib_version = LIB_VERSION;
150150

@@ -1678,11 +1678,11 @@ _.querySelectorAll = function(val){
16781678
// 替换纯数字的id
16791679
var sp = val.split(' ');
16801680
if(sp.length === 1){
1681-
if(/^#\d+$/.test(sp[0])){
1681+
if(/^#\d+/.test(sp[0])){
16821682
val = '#' + _.strToUnicode(sp[0].slice(1));
16831683
}
16841684
}else{
1685-
if(/^#\d+$/.test(sp[0])){
1685+
if(/^#\d+/.test(sp[0])){
16861686
sp[0] = '#' + _.strToUnicode(sp[0].slice(1));
16871687
val = sp.join(' ');
16881688
}
@@ -3232,7 +3232,10 @@ saEvent.send = function(p, callback) {
32323232
return false;
32333233
}
32343234
var target = ev.target || ev.srcElement;
3235-
if(!target){
3235+
if(typeof target !== 'object'){
3236+
return false;
3237+
}
3238+
if(typeof target.tagName !== 'string'){
32363239
return false;
32373240
}
32383241
var tagName = target.tagName.toLowerCase();
@@ -3257,7 +3260,10 @@ saEvent.send = function(p, callback) {
32573260
return false;
32583261
}
32593262
var target = ev.target || ev.srcElement;
3260-
if(!target){
3263+
if(typeof target !== 'object'){
3264+
return false;
3265+
}
3266+
if(typeof target.tagName !== 'string'){
32613267
return false;
32623268
}
32633269
var tagName = target.tagName.toLowerCase();

src/sensorsdata.full.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ var ObjProto = Object.prototype;
141141
var slice = ArrayProto.slice;
142142
var toString = ObjProto.toString;
143143
var hasOwnProperty = ObjProto.hasOwnProperty;
144-
var LIB_VERSION = '1.9.5';
144+
var LIB_VERSION = '1.9.6';
145145

146146
sd.lib_version = LIB_VERSION;
147147

@@ -1675,11 +1675,11 @@ _.querySelectorAll = function(val){
16751675
// 替换纯数字的id
16761676
var sp = val.split(' ');
16771677
if(sp.length === 1){
1678-
if(/^#\d+$/.test(sp[0])){
1678+
if(/^#\d+/.test(sp[0])){
16791679
val = '#' + _.strToUnicode(sp[0].slice(1));
16801680
}
16811681
}else{
1682-
if(/^#\d+$/.test(sp[0])){
1682+
if(/^#\d+/.test(sp[0])){
16831683
sp[0] = '#' + _.strToUnicode(sp[0].slice(1));
16841684
val = sp.join(' ');
16851685
}
@@ -3229,7 +3229,10 @@ saEvent.send = function(p, callback) {
32293229
return false;
32303230
}
32313231
var target = ev.target || ev.srcElement;
3232-
if(!target){
3232+
if(typeof target !== 'object'){
3233+
return false;
3234+
}
3235+
if(typeof target.tagName !== 'string'){
32333236
return false;
32343237
}
32353238
var tagName = target.tagName.toLowerCase();
@@ -3254,7 +3257,10 @@ saEvent.send = function(p, callback) {
32543257
return false;
32553258
}
32563259
var target = ev.target || ev.srcElement;
3257-
if(!target){
3260+
if(typeof target !== 'object'){
3261+
return false;
3262+
}
3263+
if(typeof target.tagName !== 'string'){
32583264
return false;
32593265
}
32603266
var tagName = target.tagName.toLowerCase();

version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
var sensorsdata_js_sdk_latest_version = '1.9.5';
1+
var sensorsdata_js_sdk_latest_version = '1.9.6';

vtrack.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)