feat(wrtag): write multi valued RELEASETYPE, write COMPILATION only if VA

closes #183

Author: sentriz

README.md

@@ -619,8 +619,8 @@ Example track is [America Is Waiting](https://musicbrainz.org/release/3b28412d-8
 | `LABEL`                      | Record label                                              | `Virgin`                                                                                                                                                                                                                     |
 | `CATALOGNUMBER`              | Catalogue number                                          | `BEDBX 1`                                                                                                                                                                                                                    |
 | `BARCODE`                    | Release barcode/UPC                                       | `0094633134126`                                                                                                                                                                                                              |
-| `COMPILATION`                | Release has type compilation / is Various Artists         | `1`                                                                                                                                                                                                                          |
-| `RELEASETYPE`                | Release primary type                                      | `album`                                                                                                                                                                                                                      |
+| `COMPILATION`                | Release is by Various Artists                             | `1`                                                                                                                                                                                                                          |
+| `RELEASETYPE`                | Release primary and secondary types (multi-valued)        | `album`, `soundtrack`                                                                                                                                                                                                        |
 | `TITLE`                      | Track title                                               | `America Is Waiting`                                                                                                                                                                                                         |
 | `ARTIST`                     | Track artist as string                                    | `Brian Eno + David Byrne`                                                                                                                                                                                                    |
 | `ARTISTS`                    | Track artist names as multi-valued tag                    | `Brian Eno`, `David Byrne`                                                                                                                                                                                                   |

musicbrainz/musicbrainz.go

@@ -452,15 +452,9 @@ func artistEnName(artist Artist) string {
 const variousArtistsMBID = "89ad4ac3-39f7-470e-963a-56509c546377"
 
 func IsCompilation(rg ReleaseGroup) bool {
-	if hasComp := slices.Contains(rg.SecondaryTypes, Compilation); hasComp {
-		return true
-	}
-	if hasVA := slices.ContainsFunc(rg.Artists, func(ac ArtistCredit) bool {
+	return slices.ContainsFunc(rg.Artists, func(ac ArtistCredit) bool {
 		return ac.Artist.ID == variousArtistsMBID
-	}); hasVA {
-		return true
-	}
-	return false
+	})
 }
 
 func FlatTracks(media []Media) []Track {

wrtag.go

@@ -503,7 +503,7 @@ func WriteRelease(
 	normtag.Set(t, normtag.CatalogueNum, trimZero(labelInfo.CatalogNumber)...)
 	normtag.Set(t, normtag.Barcode, trimZero(release.Barcode)...)
 	normtag.Set(t, normtag.Compilation, trimZero(formatBool(musicbrainz.IsCompilation(release.ReleaseGroup)))...)
-	normtag.Set(t, normtag.ReleaseType, trimZero(strings.ToLower(string(release.ReleaseGroup.PrimaryType)))...)
+	normtag.Set(t, normtag.ReleaseType, trimZero(releaseTypes(release.ReleaseGroup)...)...)
 
 	normtag.Set(t, normtag.MusicBrainzReleaseID, trimZero(release.ID)...)
 	normtag.Set(t, normtag.MusicBrainzReleaseGroupID, trimZero(release.ReleaseGroup.ID)...)
@@ -1165,6 +1165,17 @@ func trimZero[T comparable](elms ...T) []T {
 	return slices.DeleteFunc(elms, func(t T) bool { return t == zero })
 }
 
+func releaseTypes(rg musicbrainz.ReleaseGroup) []string {
+	var types []string
+	if rg.PrimaryType != "" {
+		types = append(types, strings.ToLower(string(rg.PrimaryType)))
+	}
+	for _, st := range rg.SecondaryTypes {
+		types = append(types, strings.ToLower(string(st)))
+	}
+	return types
+}
+
 func parseAnyTime(str string) time.Time {
 	t, _ := dateparse.ParseAny(str)
 	return t