Skip to content

Add get_subscription_plan(type) #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add get_subscription_plan(type) #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flask/src/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,6 @@ def evaluate_statsig_flags():
flag_values[gate] = result
except Exception as e:
print(f"Error evaluating gate {gate}: {e}")

def get_subscription_plan(type):
return 'monthly' if type == 'monthly' else 'annual'
Comment on lines +75 to +76
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter name type shadows the built-in Python type() function. This is considered bad practice as it can lead to confusion and potential bugs if the built-in function needs to be used within the function scope. Consider renaming to a more descriptive name like plan_type or subscription_type.

Did we get this right? 👍 / 👎 to inform future reviews.

Loading