Skip to content

Commit 05403ec

Browse files
Added Will's PR feedback changes
1 parent 0bb2e93 commit 05403ec

File tree

5 files changed

+47
-37
lines changed

5 files changed

+47
-37
lines changed

README.md

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
11
## Who am I
22

3+
This is demo repo is used by Solution Engineers when demo'ing Sentry's [React Native](https://docs.sentry.io/platforms/react-native) SDK's capabilties.
4+
5+
## Versions Summary:
6+
7+
| dependency | version
8+
| ------------- |:-------------:|
9+
| react-native | 0.64.0 |
10+
| gradle | 6.7 |
11+
| react | 16.13.1 |
12+
| sentry/react-native | 2.4.0 |
13+
14+
15+
16+
17+
18+
19+
20+
321
This is demo repo is used by Solution Engineers when demo'ing Sentry's [React Native](https://docs.sentry.io/platforms/react-native) SDK's capabilties.
422

523
## Where do I begin
@@ -28,14 +46,33 @@ cd ios
2846
pod install
2947
```
3048

31-
If you launch your emulator from Android Studio you may not have internet access on the emulator. Make sure to have Internet access enabled on your Android emulator. If you can't access the browser you may need to launch your emulator with the below commands from the CLI:
49+
Make sure to have Internet access enabled on your Android emulator. If you can't access the browser you may need to launch your emulator with the below commands:
3250

3351
```
3452
emulator -list-avds
3553
3654
emulator @{YourEmulator} -dns-server 8.8.8.8
3755
```
3856

57+
If you are experiencing issues with running the following launch command:
58+
59+
If the app launches and suddenly crashes you may need to reinstall your node package with this command:
60+
61+
```
62+
rm -rf node_modules
63+
64+
npm install
65+
```
66+
67+
If all else fails and you seem to be getting a weird error related to IllegalAccessErrors or anything else you may need to rebuild your Android and iOS folders using the following (just make sure to grab the sentry.properties files, build.gradle files, and pod files from Github afterwards):
68+
69+
```
70+
sudo rm -rf android/ ios/
71+
72+
yarn add react-native-eject
73+
74+
npx react-native eject
75+
```
3976

4077
### To Launch the Demo apps:
4178

@@ -97,7 +134,3 @@ cd ..
97134
```
98135
Ran git commit along the way and finally pushed to this repo.
99136

100-
## To enable a Hermes event
101-
102-
See /android/app/build.gradle
103-

android/app/build.gradle

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ import com.android.build.OutputFile
7979
* ]
8080
*/
8181

82+
// This is for enabling Hermes
8283
project.ext.react = [
8384
enableHermes: true, // clean and rebuild if changing
8485
]
@@ -191,8 +192,11 @@ dependencies {
191192
//noinspection GradleDynamicVersion
192193
implementation "com.facebook.react:react-native:0.64.0" // From node_modules
193194

195+
//AndroidX UX Widget, https://developer.android.com/jetpack/androidx/releases/swiperefreshlayout
194196
implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0"
195197

198+
//Flipper is a debugging tool for React Native, https://fbflipper.com/
199+
196200
debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") {
197201
exclude group:'com.facebook.fbjni'
198202
}
@@ -222,31 +226,4 @@ task copyDownloadableDepsToLibs(type: Copy) {
222226
into 'libs'
223227
}
224228

225-
sentry {
226-
// Disables or enables the automatic configuration of ProGuard
227-
// for Sentry. This injects a default config for ProGuard so
228-
// you don't need to do it manually.
229-
230-
// Only enable it if you are using sentry-android <= v1.7,
231-
// sentry-android >= v2.0 already does it automatically.
232-
autoProguardConfig true
233-
234-
// Enables or disables the automatic upload of mapping files
235-
// during a build. If you disable this, you'll need to manually
236-
// upload the mapping files with sentry-cli when you do a release.
237-
autoUpload true
238-
239-
// Disables or enables the automatic configuration of Native Symbols
240-
// for Sentry. This executes sentry-cli automatically so
241-
// you don't need to do it manually.
242-
// Default is disabled.
243-
uploadNativeSymbols false
244-
245-
// Does or doesn't include the source code of native code for Sentry.
246-
// This executes sentry-cli with the --include-sources param. automatically so
247-
// you don't need to do it manually.
248-
// Default is disabled.
249-
includeNativeSources false
250-
}
251-
252229
apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)

android/sentry.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
defaults.url=https://sentry.io/
22
defaults.org=testorg-az
3-
defaults.project=adamreactnative
4-
auth.token=XXXX
3+
defaults.project=reactnativeadamtest
4+
auth.token=bbece28fc4b847baaed54aa3518c5e7ced9bbaaac4404fc48f81dea11347caae

ios/sentry.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
defaults.url=https://sentry.io/
22
defaults.org=testorg-az
3-
defaults.project=mobile-webinar
4-
auth.token=XXXX
3+
defaults.project=adamreactnative
4+
auth.token=bbece28fc4b847baaed54aa3518c5e7ced9bbaaac4404fc48f81dea11347caae

src/dsn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
export const SENTRY_INTERNAL_DSN =
2-
"https://e7d16d043be64997b251cb62611f0297@o87286.ingest.sentry.io/5713490";
2+
"https://8d219253e19d4e47a689b7990c57e22f@o87286.ingest.sentry.io/5743979";

0 commit comments

Comments
 (0)